Skip to content

[SPARK-30486][BUILD] Bump lz4-java version to 1.7.1 - #27271

Closed
maropu wants to merge 1 commit into
apache:masterfrom
maropu:SPARK-30486
Closed

[SPARK-30486][BUILD] Bump lz4-java version to 1.7.1#27271
maropu wants to merge 1 commit into
apache:masterfrom
maropu:SPARK-30486

Conversation

@maropu

Copy link
Copy Markdown
Member

What changes were proposed in this pull request?

This pr intends to upgrade lz4-java from 1.7.0 to 1.7.1.

Why are the changes needed?

This release includes a bug fix for older macOS. You can see the link below for the changes;
https://github.com/lz4/lz4-java/blob/master/CHANGES.md#171

Does this PR introduce any user-facing change?

How was this patch tested?

Existing tests.

@maropu

Copy link
Copy Markdown
MemberAuthor

@maropu

Copy link
Copy Markdown
MemberAuthor

FYI: lz4/lz4-java#156

@dongjoon-hyun

dongjoon-hyun commented Jan 18, 2020

Copy link
Copy Markdown
Member

Yes, I've been waiting for this, @maropu .
However, it seems that we need to wait for one or two days because Google Maven Central is not mirroring it yet.

[ERROR] Failed to execute goal on project spark-core_2.12: Could not resolve dependencies for project org.apache.spark:spark-core_2.12:jar:3.0.0-SNAPSHOT:
Could not find artifact org.lz4:lz4-java:jar:1.7.1 in google-maven-central (
https://maven-central.storage-download.googleapis.com/repos/central/data/) -> [Help 1]

@dongjoon-hyun

Copy link
Copy Markdown
Member

The Jenkins will pass because Google Maven Central is only used in GitHub Action.
So, we can merge this when GitHub Action passes.

@kiszk

Copy link
Copy Markdown
Member

This is not available yet at https://mvnrepository.com/artifact/org.lz4/lz4-java/1.7.1, too.

@SparkQA

Copy link
Copy Markdown

Test build #116972 has finished for PR 27271 at commit bdf7bfc.

  • This patch fails due to an unknown error code, -9.
  • This patch merges cleanly.
  • This patch adds no public classes.

@kiszk

Copy link
Copy Markdown
Member

retest this please

@SparkQA

Copy link
Copy Markdown

Test build #116982 has finished for PR 27271 at commit bdf7bfc.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@kiszk

Copy link
Copy Markdown
Member

@dongjoon-hyun

Copy link
Copy Markdown
Member

Hi, @maropu and @kiszk . I found a solution for this. Could you review this?

@maropu

Copy link
Copy Markdown
MemberAuthor

Rebased to master.

@dongjoon-hyun

Copy link
Copy Markdown
Member

Thank you, @maropu !

@dongjoon-hyundongjoon-hyun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. (Pending GitHub Action)

@dongjoon-hyun

Copy link
Copy Markdown
Member

Thank you, @maropu, @kiszk , and @HyukjinKwon .
This PR already passed Jenkins and now GitHub Action also passed.
Merged to master.

@maropu

Copy link
Copy Markdown
MemberAuthor

Thanks, @dongjoon-hyun !

@SparkQA

Copy link
Copy Markdown

Test build #117051 has finished for PR 27271 at commit 3eade4b.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@maropu@dongjoon-hyun@kiszk@SparkQA@HyukjinKwon