Skip to content

[SPARK-30604][CORE] Fix a log message by including hostLocalBlockBytes to total bytes - #27320

Closed
Udbhav30 wants to merge 1 commit into
apache:masterfrom
Udbhav30:bug
Closed

[SPARK-30604][CORE] Fix a log message by including hostLocalBlockBytes to total bytes#27320
Udbhav30 wants to merge 1 commit into
apache:masterfrom
Udbhav30:bug

Conversation

@Udbhav30

@Udbhav30Udbhav30 commented Jan 22, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

Add HostLocalBlock size in log total bytes

Why are the changes needed?

total size in log is wrong as hostlocal block size is missed

Does this PR introduce any user-facing change?

no

How was this patch tested?

Manually checking the log

@Udbhav30

Udbhav30 commented Jan 22, 2020•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Hi @dongjoon-hyun can you please review this

@dongjoon-hyundongjoon-hyun changed the title [SPARK-30604 Add HostLocalBlock size in log total bytes][SPARK-30604][CORE] Add HostLocalBlock size in log total bytesJan 22, 2020
@dongjoon-hyun

dongjoon-hyun commented Jan 22, 2020

Copy link
Copy Markdown
Member

Thank you for pinging me.

@dongjoon-hyun

dongjoon-hyun commented Jan 22, 2020

Copy link
Copy Markdown
Member

ok to test

@dongjoon-hyundongjoon-hyun changed the title [SPARK-30604][CORE] Add HostLocalBlock size in log total bytes[SPARK-30604][CORE] Add hostLocalBlockBytes to total bytes in logJan 22, 2020
@dongjoon-hyundongjoon-hyun changed the title [SPARK-30604][CORE] Add hostLocalBlockBytes to total bytes in log[SPARK-30604][CORE] Fix a log message by including hostLocalBlockBytes to total bytesJan 22, 2020
@dongjoon-hyun

dongjoon-hyun commented Jan 22, 2020

Copy link
Copy Markdown
Member

@Udbhav30
BTW, why do you remove the required template? Although you cannot describe how to do, please add back and mentioned like Manually checking the log at least.

How was this patch tested?

@Udbhav30

Udbhav30 commented Jan 22, 2020

Copy link
Copy Markdown
ContributorAuthor

@Udbhav30
BTW, why do you remove the required template? Although you cannot describe how to do, please add back and mentioned like Manually checking the log at least.

How was this patch tested?

@dongjoon-hyun
Updated, thanks

@dongjoon-hyun

dongjoon-hyun commented Jan 22, 2020

Copy link
Copy Markdown
Member

Thanks!

@dongjoon-hyun

dongjoon-hyun commented Jan 22, 2020•
edited
Loading

Copy link
Copy Markdown
Member

Since this seems to be caused by SPARK-27651, cc @attilapiros and @vanzin .

@SparkQA

SparkQA commented Jan 22, 2020

Copy link
Copy Markdown

Test build #117247 has finished for PR 27320 at commit 5331053.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun

dongjoon-hyun commented Jan 22, 2020

Copy link
Copy Markdown
Member

Retest this please.

@SparkQA

SparkQA commented Jan 22, 2020

Copy link
Copy Markdown

Test build #117250 has finished for PR 27320 at commit 5331053.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun

dongjoon-hyun commented Jan 22, 2020

Copy link
Copy Markdown
Member

Merged to master.

@Udbhav30
Udbhav30 deleted the bug branch January 23, 2020 06:55
@Udbhav30
Udbhav30 restored the bug branch January 23, 2020 06:56
@Udbhav30
Udbhav30 deleted the bug branch January 23, 2020 06:58
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dongjoon-hyundongjoon-hyundongjoon-hyun approved these changes
@cloud-fancloud-fanAwaiting requested review from cloud-fan

Assignees

No one assigned

Labels

SPARK CORE

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Udbhav30@dongjoon-hyun@SparkQA