Uh oh!
There was an error while loading. Please reload this page.
[SPARK-30665][DOCS][BUILD][PYTHON] Eliminate pypandoc dependency - #27376
[SPARK-30665][DOCS][BUILD][PYTHON] Eliminate pypandoc dependency#27376nchammas wants to merge 9 commits into
Conversation
nchammas
commented
Jan 28, 2020
cc @holdenk |
SparkQA
commented
Jan 28, 2020
Test build #117496 has finished for PR 27376 at commit
|
dongjoon-hyun
commented
Jan 28, 2020
Oh, thank you for making a PR for this, @nchammas . |
dongjoon-hyun
commented
Jan 28, 2020
cc @HyukjinKwon |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
SparkQA
commented
Jan 29, 2020
Test build #117515 has finished for PR 27376 at commit
|
SparkQA
commented
Jan 29, 2020
Test build #117518 has finished for PR 27376 at commit
|
dongjoon-hyun
commented
Jan 29, 2020
BTW, this improvement should not go to |
HyukjinKwon
left a comment
There was a problem hiding this comment.
Looks fine except https://github.com/apache/spark/pull/27376/files#r372704609
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
HyukjinKwon
commented
Jan 30, 2020
@nchammas, mind updating the PR description accordingly as well? |
nchammas
commented
Jan 30, 2020
Updated the description. Also made some tweaks to the docs README to separate R prerequisites from general API doc prerequisites. Happy to make any further changes if necessary. |
SparkQA
commented
Jan 30, 2020
Test build #117533 has finished for PR 27376 at commit
|
SparkQA
commented
Jan 30, 2020
Test build #117540 has finished for PR 27376 at commit
|
HyukjinKwon
commented
Jan 30, 2020
Merged to master. |
SparkQA
commented
Jan 30, 2020
Test build #117542 has finished for PR 27376 at commit
|
What changes were proposed in this pull request?
This PR removes any dependencies on pypandoc. It also makes related tweaks to the docs README to clarify the dependency on pandoc (not pypandoc).
Why are the changes needed?
We are using pypandoc to convert the Spark README from Markdown to ReST for PyPI. PyPI now natively supports Markdown, so we don't need pypandoc anymore. The dependency on pypandoc also sometimes causes issues when installing Python packages that depend on PySpark, as described in #18981.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Manually:
I also built the PySpark and R API docs with
jekylland reviewed them locally.It would be good if a maintainer could also test this by creating a PySpark distribution and uploading it to Test PyPI to confirm the README looks as it should.