Uh oh!
There was an error while loading. Please reload this page.
[SPARK-30737][SPARK-27262][R][BUILD] Reenable CRAN check with UTF-8 encoding to DESCRIPTION - #27472
[SPARK-30737][SPARK-27262][R][BUILD] Reenable CRAN check with UTF-8 encoding to DESCRIPTION#27472HyukjinKwon wants to merge 2 commits into
Conversation
SparkQA
commented
Feb 6, 2020
Test build #117960 has finished for PR 27472 at commit
|
| # - It is strongly recommended to set environment variable TZ to | ||
| # America/Los_Angeles (or equivalent) | ||
| suppressWarnings(expect_equal(DF$time[1], as.POSIXlt("2016-01-10"))) | ||
| expect_equal(DF$time[1], as.POSIXlt("2016-01-10")) |
There was a problem hiding this comment.
This PR piggybacks one fix here. It's just rather a nit fix to don't suppress warnings anymore introduced from #27460 to make tests pass.
| RoxygenNote: 5.0.1 | ||
| VignetteBuilder: knitr | ||
| NeedsCompilation: no | ||
| Encoding: UTF-8 |
There was a problem hiding this comment.
This one, we had to revert before due to Jekins enviornment WIP. I think now it's all good to go.
HyukjinKwon
commented
Feb 6, 2020
@shivaram and @felixcheung, we will reenable CRAN here. |
shivaram
left a comment
There was a problem hiding this comment.
LGTM. Thanks @HyukjinKwon
…ncoding to DESCRIPTION ### What changes were proposed in this pull request? This PR proposes to reenable CRAN check disabled at #27460. Given the tests #27468, seems we should also port #23823 together. ### Why are the changes needed? To check CRAN back. ### Does this PR introduce any user-facing change? No. ### How was this patch tested? It was tested at #27468 and Jenkins should test it out. Closes#27472 from HyukjinKwon/SPARK-30737. Authored-by: HyukjinKwon <gurwls223@apache.org> Signed-off-by: HyukjinKwon <gurwls223@apache.org> (cherry picked from commit b95ccb1) Signed-off-by: HyukjinKwon <gurwls223@apache.org>
…ncoding to DESCRIPTION ### What changes were proposed in this pull request? This PR proposes to reenable CRAN check disabled at #27460. Given the tests #27468, seems we should also port #23823 together. ### Why are the changes needed? To check CRAN back. ### Does this PR introduce any user-facing change? No. ### How was this patch tested? It was tested at #27468 and Jenkins should test it out. Closes#27472 from HyukjinKwon/SPARK-30737. Authored-by: HyukjinKwon <gurwls223@apache.org> Signed-off-by: HyukjinKwon <gurwls223@apache.org> (cherry picked from commit b95ccb1) Signed-off-by: HyukjinKwon <gurwls223@apache.org>
HyukjinKwon
commented
Feb 6, 2020
Merged to master, branch-3.0, and branch-2.4. Thanks @shivaram |
dongjoon-hyun
commented
Feb 6, 2020
Great! Late LGTM. |
shaneknapp
commented
Feb 6, 2020
LGTM, and thanks @HyukjinKwon ! |
zero323
commented
Feb 6, 2020
Could maybe start talking about moving to Roxygen2 7.0.1, pretty please? (Documentation seems to build cleanly across all supported versions of R, with most of the files, including most of the binaries. There are no more warnings. SPARK-22430 has been resolved long time ago). |
HyukjinKwon
commented
Feb 6, 2020
That's probably less urgent but yeah we should do it. @zero323 what about creating a JIRA? |
zero323
commented
Feb 6, 2020
Yes, it is not urgent. It is mostly annoyance at this point. The reason I even ask, is that it has similar set of dependencies to |
shaneknapp
commented
Feb 6, 2020
@zero323 -- when you create the jira, assign it to me pls. thanks! |
zero323
commented
Feb 6, 2020
@shaneknapp I don't think I have permissions to do that, but here's the ticket ‒ SPARK-30747. |
What changes were proposed in this pull request?
This PR proposes to reenable CRAN check disabled at #27460. Given the tests #27468, seems we should also port #23823 together.
Why are the changes needed?
To check CRAN back.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
It was tested at #27468 and Jenkins should test it out.