Skip to content

[SPARK-30775][DOC] Improve the description of executor metrics in the monitoring documentation. - #27526

Closed
LucaCanali wants to merge 5 commits into
apache:masterfrom
LucaCanali:docPrometheusMetricsFollowupSpark29064
Closed

[SPARK-30775][DOC] Improve the description of executor metrics in the monitoring documentation.#27526
LucaCanali wants to merge 5 commits into
apache:masterfrom
LucaCanali:docPrometheusMetricsFollowupSpark29064

Conversation

@LucaCanali

@LucaCanaliLucaCanali commented Feb 10, 2020•
edited by dongjoon-hyun
Loading

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

This PR (SPARK-30775) aims to improve the description of the executor metrics in the monitoring documentation.

Why are the changes needed?

Improve and clarify monitoring documentation by:

  • adding reference to the Prometheus end point, as implemented in [SPARK-29064]
  • extending the list and descripion of executor metrics, following up from [SPARK-27157]

Does this PR introduce any user-facing change?

Documentation update.

How was this patch tested?

n.a.

@LucaCanali

LucaCanali commented Feb 12, 2020

Copy link
Copy Markdown
ContributorAuthor

@dongjoon-hyun given your work on #25770 you may want to have a look at this?

@LucaCanali
LucaCanaliforce-pushed the docPrometheusMetricsFollowupSpark29064 branch from f4b6064 to d39ceadCompareFebruary 21, 2020 09:55
@dongjoon-hyun

dongjoon-hyun commented Mar 30, 2020

Copy link
Copy Markdown
Member

ok to test

dongjoon-hyun
dongjoon-hyun reviewed Mar 30, 2020
View reviewed changes
Comment threaddocs/monitoring.md Outdated
dongjoon-hyun
dongjoon-hyun reviewed Mar 30, 2020
View reviewed changes
Comment threaddocs/monitoring.md Outdated
dongjoon-hyun
dongjoon-hyun reviewed Mar 30, 2020
View reviewed changes
Comment threaddocs/monitoring.md Outdated
dongjoon-hyun
dongjoon-hyun requested changes Mar 30, 2020
View reviewed changes

@dongjoon-hyundongjoon-hyun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks the table layout of HTML.
Could you generate the html file and verify the result?

@SparkQA

SparkQA commented Mar 30, 2020

Copy link
Copy Markdown

Test build #120569 has finished for PR 27526 at commit d39cead.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA

SparkQA commented Mar 30, 2020

Copy link
Copy Markdown

Test build #120589 has finished for PR 27526 at commit 3ae4a14.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@LucaCanali

LucaCanali commented Mar 30, 2020

Copy link
Copy Markdown
ContributorAuthor

This breaks the table layout of HTML.
Indeed, it should be fixed now.

Could you generate the html file and verify the result?
For the moment I have checked with HTML rendering on Github and the table looks OK now.

@SparkQA

SparkQA commented Mar 30, 2020

Copy link
Copy Markdown

Test build #120594 has finished for PR 27526 at commit 0fc3f2a.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

dongjoon-hyun
dongjoon-hyun approved these changes Mar 31, 2020
View reviewed changes

@dongjoon-hyundongjoon-hyun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating, @LucaCanali . +1, LGTM.
Merged to master.
Since RC1 tag is already created, I will cherry-pick this to branch-3.0 after RC1 failure.

@LucaCanali

LucaCanali commented Mar 31, 2020

Copy link
Copy Markdown
ContributorAuthor

Thank you @dongjoon-hyun

dongjoon-hyun pushed a commit that referenced this pull request Mar 31, 2020
@LucaCanali@dongjoon-hyun
[SPARK-30775][DOC] Improve the description of executor metrics in the…
ca3887a
… monitoring documentation
### What changes were proposed in this pull request?
This PR (SPARK-30775) aims to improve the description of the executor metrics in the monitoring documentation.
### Why are the changes needed?
Improve and clarify monitoring documentation by:
- adding reference to the Prometheus end point, as implemented in [SPARK-29064]
- extending the list and descripion of executor metrics, following up from [SPARK-27157]
### Does this PR introduce any user-facing change?
Documentation update.
### How was this patch tested?
n.a.
Closes#27526 from LucaCanali/docPrometheusMetricsFollowupSpark29064.
Authored-by: Luca Canali <luca.canali@cern.ch>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
(cherry picked from commit aa98ac5)
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
sjincho pushed a commit to sjincho/spark that referenced this pull request Apr 15, 2020
@LucaCanaliSeongjin Cho
[SPARK-30775][DOC] Improve the description of executor metrics in the…
a4b34c9
… monitoring documentation
### What changes were proposed in this pull request?
This PR (SPARK-30775) aims to improve the description of the executor metrics in the monitoring documentation.
### Why are the changes needed?
Improve and clarify monitoring documentation by:
- adding reference to the Prometheus end point, as implemented in [SPARK-29064]
- extending the list and descripion of executor metrics, following up from [SPARK-27157]
### Does this PR introduce any user-facing change?
Documentation update.
### How was this patch tested?
n.a.
Closesapache#27526 from LucaCanali/docPrometheusMetricsFollowupSpark29064.
Authored-by: Luca Canali <luca.canali@cern.ch>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dongjoon-hyundongjoon-hyundongjoon-hyun approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@LucaCanali@dongjoon-hyun@SparkQA