Skip to content

[SPARK-30922] [SQL] remove the max splits config in skewed join - #27673

Closed
JkSelf wants to merge 1 commit into
apache:masterfrom
JkSelf:removeMaxSplitNum
Closed

[SPARK-30922] [SQL] remove the max splits config in skewed join#27673
JkSelf wants to merge 1 commit into
apache:masterfrom
JkSelf:removeMaxSplitNum

Conversation

@JkSelf

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

When skewed join optimization split more skewed readers, the plan may be very large and can not be shown in ui quickly. The config spark.sql.adaptive.skewedJoinOptimization.skewedPartitionMaxSplits is to resolve the above ui shown issue. And after PR#27493 combined the skewed readers into one, we not need this config.

Why are the changes needed?

remove the unnecessary config

Does this PR introduce any user-facing change?

No

How was this patch tested?

existing test

@JkSelf

Copy link
Copy Markdown
ContributorAuthor

@SparkQA

Copy link
Copy Markdown

Test build #118808 has finished for PR 27673 at commit 8bbfe24.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@cloud-fan

Copy link
Copy Markdown
Contributor

thanks, merging to master/3.0!

cloud-fan pushed a commit that referenced this pull request Feb 24, 2020
### What changes were proposed in this pull request?
When skewed join optimization split more skewed readers, the plan may be very large and can not be shown in ui quickly. The config `spark.sql.adaptive.skewedJoinOptimization.skewedPartitionMaxSplits` is to resolve the above ui shown issue. And after [PR#27493](#27493) combined the skewed readers into one, we not need this config.
### Why are the changes needed?
remove the unnecessary config
### Does this PR introduce any user-facing change?
No
### How was this patch tested?
existing test
Closes#27673 from JkSelf/removeMaxSplitNum.
Authored-by: jiake <ke.a.jia@intel.com>
Signed-off-by: Wenchen Fan <wenchen@databricks.com>
(cherry picked from commit f4696ba)
Signed-off-by: Wenchen Fan <wenchen@databricks.com>
sjincho pushed a commit to sjincho/spark that referenced this pull request Apr 15, 2020
### What changes were proposed in this pull request?
When skewed join optimization split more skewed readers, the plan may be very large and can not be shown in ui quickly. The config `spark.sql.adaptive.skewedJoinOptimization.skewedPartitionMaxSplits` is to resolve the above ui shown issue. And after [PR#27493](apache#27493) combined the skewed readers into one, we not need this config.
### Why are the changes needed?
remove the unnecessary config
### Does this PR introduce any user-facing change?
No
### How was this patch tested?
existing test
Closesapache#27673 from JkSelf/removeMaxSplitNum.
Authored-by: jiake <ke.a.jia@intel.com>
Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@JkSelf@SparkQA@cloud-fan