Skip to content

SPARK-1365 [HOTFIX] Fix RateLimitedOutputStream test - #277

Closed
pwendell wants to merge 1 commit into
apache:masterfrom
pwendell:rate-limited-stream
Closed

SPARK-1365 [HOTFIX] Fix RateLimitedOutputStream test#277
pwendell wants to merge 1 commit into
apache:masterfrom
pwendell:rate-limited-stream

Conversation

@pwendell

@pwendellpwendell commented Mar 31, 2014

Copy link
Copy Markdown
Contributor

This test needs to be fixed. It currently depends on Thread.sleep() having exact-timing
semantics, which is not a valid assumption.

@rxin

rxin commented Mar 31, 2014

Copy link
Copy Markdown
Contributor

How about just making sure it has a lower bound of 4?

@AmplabJenkins

AmplabJenkins commented Mar 31, 2014

Copy link
Copy Markdown

Merged build triggered. Build is starting -or- tests failed to complete.

@AmplabJenkins

AmplabJenkins commented Mar 31, 2014

Copy link
Copy Markdown

Merged build started. Build is starting -or- tests failed to complete.

@pwendell

pwendell commented Mar 31, 2014

Copy link
Copy Markdown
ContributorAuthor

@rxin didn't know whether that was what @tdas would want... we should probably try to upper bound the test some-how because this is a test of rate limiting.

@rxin

rxin commented Mar 31, 2014

Copy link
Copy Markdown
Contributor

rate limiting was about setting an upper bound in throughput, and thus lower bound in time.

@AmplabJenkins

AmplabJenkins commented Mar 31, 2014

Copy link
Copy Markdown

Merged build finished. Build is starting -or- tests failed to complete.

@AmplabJenkins

AmplabJenkins commented Mar 31, 2014

Copy link
Copy Markdown

Build is starting -or- tests failed to complete.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13598/

@pwendell

pwendell commented Mar 31, 2014

Copy link
Copy Markdown
ContributorAuthor

@rxin true, but that's like saying an eventual consistency implementation that never converges is okay. I.e. we want to test that it isn't just a no-op stream that never passes data through.

@pwendell

pwendell commented Mar 31, 2014

Copy link
Copy Markdown
ContributorAuthor

@rxin I'll just add a conservative upper bound also to make sure it does eventually get through.

@pwendellpwendell changed the title SPARK-1365 [HOTFIX] Disable RateLimitedOutputStream testSPARK-1365 [HOTFIX] Fix RateLimitedOutputStream testMar 31, 2014
@pwendell
SPARK-1365: Fix RateLimitedOutputStream test
6c0ff81
This test needs to be fixed. It currently depends on Thread.sleep() having exact-timing
semantics, which is not a valid assumption.
@AmplabJenkins

AmplabJenkins commented Mar 31, 2014

Copy link
Copy Markdown

Merged build triggered. Build is starting -or- tests failed to complete.

@AmplabJenkins

AmplabJenkins commented Mar 31, 2014

Copy link
Copy Markdown

Merged build started. Build is starting -or- tests failed to complete.

@AmplabJenkins

AmplabJenkins commented Mar 31, 2014

Copy link
Copy Markdown

Merged build finished. All automated tests passed.

@AmplabJenkins

AmplabJenkins commented Mar 31, 2014

Copy link
Copy Markdown

All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13602/

pdeyhim pushed a commit to pdeyhim/spark-1 that referenced this pull request Jun 25, 2014
@pwendell@pdeyhim
SPARK-1365 [HOTFIX] Fix RateLimitedOutputStream test
203dad2
This test needs to be fixed. It currently depends on Thread.sleep() having exact-timing
semantics, which is not a valid assumption.
Author: Patrick Wendell <pwendell@gmail.com>
Closesapache#277 from pwendell/rate-limited-stream and squashes the following commits:
6c0ff81 [Patrick Wendell] SPARK-1365: Fix RateLimitedOutputStream test
Igosuki pushed a commit to Adikteev/spark that referenced this pull request Jul 31, 2018
@djannot@susanxhuynh
[DOCS] Fixing several typos and configuration issues in "Secure ML Pi…
4b6b041
…peline" page (apache#277)
bzhaoopenstack pushed a commit to bzhaoopenstack/spark that referenced this pull request Sep 11, 2019
@liusheng@kiwik
Add support for running docker machine tests against public clouds (a…
b770751
…pache#277)
@peter-tothpeter-toth mentioned this pull request Mar 25, 2020
Closed
arjunshroff pushed a commit to arjunshroff/spark that referenced this pull request Nov 24, 2020
@ekrivokonmapr
Spark 226 (apache#277)
72b3f9d
* MapR [SPARK-226] Spark - pySpark Security Vulnerability
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pwendell@rxin@AmplabJenkins