Uh oh!
There was an error while loading. Please reload this page.
[SPARK-31291][SQL][TEST][FOLLOWUP] Fix resource loading error in ThriftServerQueryTestSuite - #28186
Closed
dongjoon-hyun wants to merge 2 commits into
Closed
[SPARK-31291][SQL][TEST][FOLLOWUP] Fix resource loading error in ThriftServerQueryTestSuite#28186dongjoon-hyun wants to merge 2 commits into
dongjoon-hyun wants to merge 2 commits into
Conversation
…ftServerQueryTestSuite
dongjoon-hyun
commented
Apr 11, 2020
MemberAuthor
cc @beliefer , @cloud-fan , @maropu , @gatorsmile . |
This comment has been minimized.
This comment has been minimized.
dongjoon-hyun
commented
Apr 11, 2020
MemberAuthor
Retest this please. |
SparkQA
commented
Apr 11, 2020
Test build #121117 has finished for PR 28186 at commit
|
maropu
reviewed
Apr 11, 2020
Uh oh!
There was an error while loading. Please reload this page.
maropu
reviewed
Apr 11, 2020
Uh oh!
There was an error while loading. Please reload this page.
maropu
approved these changes
Apr 11, 2020
dongjoon-hyun
commented
Apr 11, 2020
MemberAuthor
Thank you for review and approval, @maropu ! |
SparkQA
commented
Apr 11, 2020
Test build #121118 has finished for PR 28186 at commit
|
maropu
commented
Apr 11, 2020
Member
retest this please |
dongjoon-hyun
commented
Apr 11, 2020
MemberAuthor
Thank you for retriggering. |
SparkQA
commented
Apr 11, 2020
Test build #121124 has finished for PR 28186 at commit
|
dongjoon-hyun
commented
Apr 11, 2020
MemberAuthor
Thanks you. Merged to master/3.0. |
dongjoon-hyun added a commit
that referenced
this pull request
Apr 11, 2020
…ftServerQueryTestSuite ### What changes were proposed in this pull request? [SPARK-31291](#28060) broke `ThriftServerQueryTestSuite` in Maven environment. This PR fixes it by copying the resource file from jars to local temp file. ### Why are the changes needed? To recover the Jenkins jobs in `master` and `branch-3.0`. - https://amplab.cs.berkeley.edu/jenkins/view/Spark%20QA%20Test%20(Dashboard)/job/spark-branch-3.0-test-maven-hadoop-2.7-hive-2.3/211/ ``` org.apache.spark.sql.hive.thriftserver.ThriftServerQueryTestSuite *** ABORTED *** ... java.lang.IllegalArgumentException: java.net.URISyntaxException: Relative path in absolute URI: jar:file:/home/jenkins/workspace/spark-branch-3.0-test-maven-hadoop-2.7-hive-2.3/sql/core/target/ spark-sql_2.12-3.0.1-SNAPSHOT-tests.jar!/test-data/postgresql/agg.data ```  ### Does this PR introduce any user-facing change? No. ### How was this patch tested? Pass the Jenkins with SBT and Maven. - [x] Sbt (`Test build #121117` #28186 (comment)) - [x] Maven (`Test build #121118` #28186 (comment)) Closes#28186 from dongjoon-hyun/SPARK-31291. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit b4c438a) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
sjincho pushed a commit
to sjincho/spark
that referenced
this pull request
Apr 15, 2020
…ftServerQueryTestSuite ### What changes were proposed in this pull request? [SPARK-31291](apache#28060) broke `ThriftServerQueryTestSuite` in Maven environment. This PR fixes it by copying the resource file from jars to local temp file. ### Why are the changes needed? To recover the Jenkins jobs in `master` and `branch-3.0`. - https://amplab.cs.berkeley.edu/jenkins/view/Spark%20QA%20Test%20(Dashboard)/job/spark-branch-3.0-test-maven-hadoop-2.7-hive-2.3/211/ ``` org.apache.spark.sql.hive.thriftserver.ThriftServerQueryTestSuite *** ABORTED *** ... java.lang.IllegalArgumentException: java.net.URISyntaxException: Relative path in absolute URI: jar:file:/home/jenkins/workspace/spark-branch-3.0-test-maven-hadoop-2.7-hive-2.3/sql/core/target/ spark-sql_2.12-3.0.1-SNAPSHOT-tests.jar!/test-data/postgresql/agg.data ```  ### Does this PR introduce any user-facing change? No. ### How was this patch tested? Pass the Jenkins with SBT and Maven. - [x] Sbt (`Test build #121117` apache#28186 (comment)) - [x] Maven (`Test build #121118` apache#28186 (comment)) Closesapache#28186 from dongjoon-hyun/SPARK-31291. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
SPARK-31291 broke
ThriftServerQueryTestSuitein Maven environment. This PR fixes it by copying the resource file from jars to local temp file.Why are the changes needed?
To recover the Jenkins jobs in
masterandbranch-3.0.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the Jenkins with SBT and Maven.
Test build #121117[SPARK-31291][SQL][TEST][FOLLOWUP] Fix resource loading error in ThriftServerQueryTestSuite #28186 (comment))Test build #121118[SPARK-31291][SQL][TEST][FOLLOWUP] Fix resource loading error in ThriftServerQueryTestSuite #28186 (comment))