Uh oh!
There was an error while loading. Please reload this page.
[SPARK-31468][SQL] Null types should be implicitly casted to Decimal types - #28241
Closed
maropu wants to merge 1 commit into
Closed
[SPARK-31468][SQL] Null types should be implicitly casted to Decimal types#28241maropu wants to merge 1 commit into
maropu wants to merge 1 commit into
Conversation
SparkQA
commented
Apr 17, 2020
Test build #121404 has finished for PR 28241 at commit
|
maropu
commented
Apr 17, 2020
MemberAuthor
cloud-fan
commented
Apr 17, 2020
Contributor
good catch! LGTM |
cloud-fan
commented
Apr 17, 2020
Contributor
merging to master/3.0 |
cloud-fan pushed a commit
that referenced
this pull request
Apr 17, 2020
…types
### What changes were proposed in this pull request?
This PR intends to fix a bug that occurs when comparing null types to decimal types in master/branch-3.0;
```
scala> Seq(BigDecimal(10)).toDF("v1").selectExpr("v1 = NULL").explain(true)
org.apache.spark.sql.AnalysisException: cannot resolve '(`v1` = NULL)' due to data type mismatch: differing types in '(`v1` = NULL)' (decimal(38,18) and null).; line 1 pos 0;
'Project [(v1#5 = null) AS (v1 = NULL)#7]
+- Project [value#2 AS v1#5]
+- LocalRelation [value#2]
...
```
The query above passed in v2.4.5.
### Why are the changes needed?
bugfix
### Does this PR introduce any user-facing change?
No.
### How was this patch tested?
Added tests.
Closes#28241 from maropu/SPARK-31468.
Authored-by: Takeshi Yamamuro <yamamuro@apache.org>
Signed-off-by: Wenchen Fan <wenchen@databricks.com>
(cherry picked from commit a7fb330)
Signed-off-by: Wenchen Fan <wenchen@databricks.com>maropu
commented
Apr 17, 2020
MemberAuthor
Thanks for the quick response, @cloud-fan ! |
maropu
commented
Apr 17, 2020
MemberAuthor
Thanks always, @viirya |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR intends to fix a bug that occurs when comparing null types to decimal types in master/branch-3.0;
The query above passed in v2.4.5.
Why are the changes needed?
bugfix
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Added tests.