Skip to content

[SPARK-31532][SPARK-31234][SQL][FOLLOWUP] Use lowercases for GLOBAL_TEMP_DATABASE config in SparkSessionBuilderSuite - #28338

Closed
maropu wants to merge 1 commit into
apache:masterfrom
maropu:SPARK-31532-FOLLOWUP
Closed

[SPARK-31532][SPARK-31234][SQL][FOLLOWUP] Use lowercases for GLOBAL_TEMP_DATABASE config in SparkSessionBuilderSuite#28338
maropu wants to merge 1 commit into
apache:masterfrom
maropu:SPARK-31532-FOLLOWUP

Conversation

@maropu

@maropumaropu commented Apr 25, 2020

Copy link
Copy Markdown
Member

What changes were proposed in this pull request?

This PR intends to fix test code for using lowercases for the GLOBAL_TEMP_DATABASE config in SparkSessionBuilderSuite. The handling of the config is different between branch-3.0+ and branch-2.4. In branch-3.0+, Spark always lowercases a value in the config, so I think we had better always use lowercases for it in the test.

This comes from the @dongjoon-hyun
comment: #28316 (comment)

Why are the changes needed?

To fix the test failure in branch-2.4.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Fixed the test.

@maropu

Copy link
Copy Markdown
MemberAuthor

@yaooqinn

yaooqinn commented Apr 25, 2020

Copy link
Copy Markdown
Member

LGTM. shall we tag SPARK-31234 too? maybe add some comment with the change

@maropumaropu changed the title [SPARK-31532][SQL][FOLLOWUP] Use lowercases for GLOBAL_TEMP_DATABASE config in SparkSessionBuilderSuite[SPARK-31532][SPARK-31234][SQL][FOLLOWUP] Use lowercases for GLOBAL_TEMP_DATABASE config in SparkSessionBuilderSuiteApr 25, 2020
@dongjoon-hyun

dongjoon-hyun commented Apr 25, 2020

Copy link
Copy Markdown
Member

Hi, @maropu .
Sorry. I wasn't clear enough. I meant a follow PR for branch-2.4 only and to change the string in assert. We should keep .config(GLOBAL_TEMP_DATABASE.key, ... part for test coverage.

@maropu

Copy link
Copy Markdown
MemberAuthor

Ah, I see. I'll close this.

@maropumaropu closed this Apr 25, 2020
@SparkQA

Copy link
Copy Markdown

Test build #121793 has finished for PR 28338 at commit fea2375.

  • This patch fails due to an unknown error code, -9.
  • This patch merges cleanly.
  • This patch adds no public classes.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@maropu@yaooqinn@dongjoon-hyun@SparkQA