Skip to content

[SPARK-31372][SQL][TEST][FOLLOWUP][3.0] Update the golden file of ExpressionsSchemaSuite - #28427

Closed
maropu wants to merge 2 commits into
apache:branch-3.0from
maropu:SPARK-31372-FOLLOWUP
Closed

[SPARK-31372][SQL][TEST][FOLLOWUP][3.0] Update the golden file of ExpressionsSchemaSuite#28427
maropu wants to merge 2 commits into
apache:branch-3.0from
maropu:SPARK-31372-FOLLOWUP

Conversation

@maropu

@maropumaropu commented May 1, 2020•
edited
Loading

Copy link
Copy Markdown
Member

What changes were proposed in this pull request?

This PR is a follow-up PR to update the golden file of ExpressionsSchemaSuite.

Why are the changes needed?

To recover tests in branch-3.0.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Existing tests.

@maropumaropu mentioned this pull request May 1, 2020
Closed
@maropu

maropu commented May 1, 2020

Copy link
Copy Markdown
MemberAuthor

cc: @dongjoon-hyun

@maropumaropu changed the title [SPARK-31372][SQL][TEST][FOLLOWUP][3.0] Update the golden file of byExpressionsSchemaSuite[SPARK-31372][SQL][TEST][FOLLOWUP][3.0] Update the golden file of ExpressionsSchemaSuiteMay 1, 2020
HyukjinKwon
HyukjinKwon approved these changes May 1, 2020
View reviewed changes

@HyukjinKwonHyukjinKwon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for a quick fix. LGTM

@maropu

maropu commented May 1, 2020

Copy link
Copy Markdown
MemberAuthor

Thanks for the quick response, @HyukjinKwon ;)

cloud-fan
cloud-fan approved these changes May 1, 2020
View reviewed changes

@cloud-fancloud-fan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing!

@beliefer

beliefer commented May 1, 2020

Copy link
Copy Markdown
Contributor

@maropu, It seems we not change the schema of rand() in branch-3.0? Why we preserve the distinguish between master and branch-3.0 ?

@maropu

maropu commented May 1, 2020

Copy link
Copy Markdown
MemberAuthor

Ah, yes. We need to ignore them in branch-3.0. I'll update.

@SparkQA

SparkQA commented May 1, 2020

Copy link
Copy Markdown

Test build #122155 has finished for PR 28427 at commit 948a54e.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

HyukjinKwon
HyukjinKwon reviewed May 1, 2020
View reviewed changes
Comment threadsql/core/src/test/resources/sql-functions/sql-expression-schema.md
| org.apache.spark.sql.catalyst.expressions.RLike | rlike | SELECT '%SystemDrive%\Users\John' rlike '%SystemDrive%\\Users.*' | struct<%SystemDrive%UsersJohn RLIKE %SystemDrive%\Users.*:boolean> |
| org.apache.spark.sql.catalyst.expressions.Rand | random | SELECT random() | struct<rand():double> |
| org.apache.spark.sql.catalyst.expressions.Rand | rand | SELECT rand() | struct<rand():double> |
| org.apache.spark.sql.catalyst.expressions.Randn | randn | SELECT randn() | struct<randn():double> |

@HyukjinKwonHyukjinKwonMay 1, 2020•
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think @beliefer meant #28392 is only landed into master and we should keep these just as are at #28194. I assume rand(seed) was printed out because this test was ran against the latest master instead of branch-3.0 at 948a54e (?).

@maropumaropuMay 1, 2020

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, I think this golden file was generated in master, so I re-generated it in branch-3.0. Btw, we need this test suite in branch-3.0? Reverting #28194 from branch-3.0 is another simple solution to recover it, I think.

@cloud-fancloud-fanMay 1, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test is useful to track the auto-alias name change history. It would be nice to have it in 3.0.

@SparkQA

SparkQA commented May 1, 2020

Copy link
Copy Markdown

Test build #122158 has finished for PR 28427 at commit db16f76.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@maropu

maropu commented May 1, 2020

Copy link
Copy Markdown
MemberAuthor

Thanks, all. Merged to branch-3.0.

@maropumaropu closed this May 1, 2020
maropu added a commit that referenced this pull request May 1, 2020
@maropu
[SPARK-31372][SQL][TEST][FOLLOWUP][3.0] Update the golden file of Exp…
7c6b970
…ressionsSchemaSuite
### What changes were proposed in this pull request?
This PR is a follow-up PR to update the golden file of `ExpressionsSchemaSuite`.
### Why are the changes needed?
To recover tests in branch-3.0.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Existing tests.
Closes#28427 from maropu/SPARK-31372-FOLLOWUP.
Authored-by: Takeshi Yamamuro <yamamuro@apache.org>
Signed-off-by: Takeshi Yamamuro <yamamuro@apache.org>
@dongjoon-hyun

dongjoon-hyun commented May 1, 2020•
edited
Loading

Copy link
Copy Markdown
Member

+1, late LGTM. Thank you for quick fix. :)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cloud-fancloud-fancloud-fan approved these changes
@HyukjinKwonHyukjinKwonHyukjinKwon approved these changes

Assignees

No one assigned

Labels

SQL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@maropu@beliefer@SparkQA@dongjoon-hyun@cloud-fan@HyukjinKwon