Uh oh!
There was an error while loading. Please reload this page.
[SPARK-31526][SQL][TESTS][FOLLOWUP] Make ExpressionInfo independent from local time zone - #28538
Closed
MaxGekk wants to merge 1 commit into
Closed
[SPARK-31526][SQL][TESTS][FOLLOWUP] Make ExpressionInfo independent from local time zone#28538MaxGekk wants to merge 1 commit into
MaxGekk wants to merge 1 commit into
Conversation
MaxGekk
commented
May 15, 2020
MemberAuthor
@maropu@gengliangwang@cloud-fan@HyukjinKwon Please, review this PR. |
gengliangwang
approved these changes
May 15, 2020
cloud-fan
approved these changes
May 15, 2020
maropu
approved these changes
May 15, 2020
SparkQA
commented
May 15, 2020
Test build #122661 has finished for PR 28538 at commit
|
MaxGekk
commented
May 15, 2020
MemberAuthor
The failure in |
MaxGekk
commented
May 15, 2020
MemberAuthor
jenkins, retest this, please |
SparkQA
commented
May 15, 2020
Test build #122671 has finished for PR 28538 at commit
|
MaxGekk
commented
May 15, 2020
MemberAuthor
jenkins, retest this, please |
SparkQA
commented
May 16, 2020
Test build #122692 has finished for PR 28538 at commit
|
MaxGekk
commented
May 16, 2020
MemberAuthor
jenkins, retest this, please |
maropu
commented
May 16, 2020
Member
hm, pretty flaky... |
SparkQA
commented
May 16, 2020
Test build #122702 has finished for PR 28538 at commit
|
MaxGekk
commented
May 16, 2020
MemberAuthor
jenkins, retest this, please |
SparkQA
commented
May 16, 2020
Test build #122720 has finished for PR 28538 at commit
|
cloud-fan pushed a commit
that referenced
this pull request
May 17, 2020
… Locale.US in tests by default ### What changes were proposed in this pull request? Set default time zone and locale in the default constructor of `SparkFunSuite`: - Default time zone to `America/Los_Angeles` - Default locale to `Locale.US` ### Why are the changes needed? 1. To deduplicate code by moving common time zone and locale settings to one place SparkFunSuite 2. To have the same default time zone and locale in all tests. This should prevent errors like #28538 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? by running all affected test suites Closes#28548 from MaxGekk/timezone-settings-SparkFunSuite. Authored-by: Max Gekk <max.gekk@gmail.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com> (cherry picked from commit 5539ecf) Signed-off-by: Wenchen Fan <wenchen@databricks.com>
cloud-fan pushed a commit
that referenced
this pull request
May 17, 2020
… Locale.US in tests by default ### What changes were proposed in this pull request? Set default time zone and locale in the default constructor of `SparkFunSuite`: - Default time zone to `America/Los_Angeles` - Default locale to `Locale.US` ### Why are the changes needed? 1. To deduplicate code by moving common time zone and locale settings to one place SparkFunSuite 2. To have the same default time zone and locale in all tests. This should prevent errors like #28538 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? by running all affected test suites Closes#28548 from MaxGekk/timezone-settings-SparkFunSuite. Authored-by: Max Gekk <max.gekk@gmail.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
dongjoon-hyun
commented
May 17, 2020
Member
Since SPARK-31725 improves |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Extend QueryTest instead of SparkFunSuite in ExpressionInfoSuite as in SQLQuerySuite.
Why are the changes needed?
After the changes #28308, the moved tests from SQLQuerySuite became dependent from local time zone settings. And tests from ExpressionInfoSuite fail if they run not in the
America/Los_Angelestime zone:Does this PR introduce any user-facing change?
No
How was this patch tested?
By running the modified test suite locally in the
Europe/Moscowtime zone: