Skip to content

[SPARK-31876][BUILD] Upgrade to Zstd 1.4.5 - #28682

Closed
williamhyun wants to merge 1 commit into
apache:masterfrom
williamhyun:zstd
Closed

[SPARK-31876][BUILD] Upgrade to Zstd 1.4.5#28682
williamhyun wants to merge 1 commit into
apache:masterfrom
williamhyun:zstd

Conversation

@williamhyun

@williamhyunwilliamhyun commented May 31, 2020

Copy link
Copy Markdown
Member

What changes were proposed in this pull request?

This PR aims to upgrade to Zstd 1.4.5.

Why are the changes needed?

Zstd 1.4.5 improves performance.

https://github.com/facebook/zstd/releases/tag/v1.4.5

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Passed the Jenkins.

@williamhyunwilliamhyun changed the title Use Zstd 1.4.5[SPARK-XXX][BUILD] Upgrade to Ztd 1.4.5May 31, 2020
@williamhyunwilliamhyun changed the title [SPARK-XXX][BUILD] Upgrade to Ztd 1.4.5[SPARK-XXX][BUILD] Upgrade to Zstd 1.4.5May 31, 2020
@SparkQA

Copy link
Copy Markdown

Test build #123329 has finished for PR 28682 at commit 3de543c.

  • This patch fails due to an unknown error code, -9.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon

Copy link
Copy Markdown
Member

retest this please

@HyukjinKwon

Copy link
Copy Markdown
Member

@williamhyun Can you file a JIRA?

@SparkQA

Copy link
Copy Markdown

Test build #123344 has finished for PR 28682 at commit 3de543c.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@williamhyunwilliamhyun changed the title [SPARK-XXX][BUILD] Upgrade to Zstd 1.4.5[SPARK-31876][BUILD] Upgrade to Zstd 1.4.5May 31, 2020
@williamhyun

Copy link
Copy Markdown
MemberAuthor

Sure, I filed SPARK-31876 and updated the PR title.

@srowen

Copy link
Copy Markdown
Member

Looks OK if there are no compatibility concerns.

@dbtsai

Copy link
Copy Markdown
Member

LGTM. Merged into master.

@dbtsaidbtsai closed this in 367d94aJun 2, 2020
holdenk pushed a commit to holdenk/spark that referenced this pull request Oct 27, 2020
### What changes were proposed in this pull request?
This PR aims to upgrade to Zstd 1.4.5.
### Why are the changes needed?
Zstd 1.4.5 improves performance.
https://github.com/facebook/zstd/releases/tag/v1.4.5
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Passed the Jenkins.
Closesapache#28682 from williamhyun/zstd.
Authored-by: William Hyun <williamhyun3@gmail.com>
Signed-off-by: DB Tsai <d_tsai@apple.com>
otterc pushed a commit to linkedin/spark that referenced this pull request Mar 22, 2023
This PR aims to upgrade to Zstd 1.4.5.
Zstd 1.4.5 improves performance.
https://github.com/facebook/zstd/releases/tag/v1.4.5
No.
Passed the Jenkins.
Closesapache#28682 from williamhyun/zstd.
Authored-by: William Hyun <williamhyun3@gmail.com>
Signed-off-by: DB Tsai <d_tsai@apple.com>
(cherry picked from commit 367d94a)
RB=3332514
BUG=LIHADOOP-63952
G=spark-reviewers
R=tgudivad,ekrogen
A=ekrogen
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@williamhyun@SparkQA@HyukjinKwon@srowen@dbtsai