Uh oh!
There was an error while loading. Please reload this page.
[SPARK-24634][SS][FOLLOWUP] Rename the variable from "numLateInputs" to "numRowsDroppedByWatermark" - #28828
[SPARK-24634][SS][FOLLOWUP] Rename the variable from "numLateInputs" to "numRowsDroppedByWatermark"#28828HeartSaVioR wants to merge 6 commits into
Conversation
…to "numDropppedRowsByWatermark"
HeartSaVioR
commented
Jun 14, 2020
cc. @zsxwing |
SparkQA
commented
Jun 14, 2020
Test build #124013 has finished for PR 28828 at commit
|
SparkQA
commented
Jun 15, 2020
Test build #124017 has finished for PR 28828 at commit
|
SparkQA
commented
Jun 15, 2020
Test build #124015 has finished for PR 28828 at commit
|
HyukjinKwon
commented
Jun 15, 2020
@xuanyuanking too FYI |
xuanyuanking
left a comment
There was a problem hiding this comment.
LGTM, thanks for the quick follow-up.
HyukjinKwon
left a comment
There was a problem hiding this comment.
Looks good to me too. I will merge in few days.
Uh oh!
There was an error while loading. Please reload this page.
SparkQA
commented
Jun 15, 2020
Test build #124040 has finished for PR 28828 at commit
|
zsxwing
left a comment
There was a problem hiding this comment.
Left one minor comment. Otherwise LGTM. Thanks for fixing this!
Uh oh!
There was an error while loading. Please reload this page.
SparkQA
commented
Jun 15, 2020
Test build #124073 has finished for PR 28828 at commit
|
SparkQA
commented
Jun 16, 2020
Test build #124074 has finished for PR 28828 at commit
|
HyukjinKwon
commented
Jun 16, 2020
Merged to master. |
HeartSaVioR
commented
Jun 16, 2020
Thanks all for reviewing and merging! |
What changes were proposed in this pull request?
This PR renames the variable from "numLateInputs" to "numRowsDroppedByWatermark" so that it becomes self-explanation.
Why are the changes needed?
This is originated from post-review, see #28607 (comment)
Does this PR introduce any user-facing change?
No, as SPARK-24634 is not introduced in any release yet.
How was this patch tested?
Existing UTs.