[SPARK-32130][SQL][FOLLOWUP] Enable timestamps inference in JsonBenchmark - #28981
Closed
MaxGekk wants to merge 3 commits into
Closed
[SPARK-32130][SQL][FOLLOWUP] Enable timestamps inference in JsonBenchmark#28981MaxGekk wants to merge 3 commits into
MaxGekk wants to merge 3 commits into
Conversation
Member
Author
|
@dongjoon-hyun May I ask you to review this PR. |
Member
|
Thank you for a quick follow-up~ |
| read date from files 16583 16612 29 0.6 1658.3 0.2X | ||
| timestamp strings 3927 3963 40 2.5 392.7 0.7X | ||
| parse timestamps from Dataset[String] 52827 53004 243 0.2 5282.7 0.0X | ||
| infer timestamps from Dataset[String] 101108 101644 769 0.1 10110.8 0.0X |
| from_json(date) 43755 43782 27 0.2 4375.5 0.1X | ||
| read timestamp text from files 2616 2641 34 3.8 261.6 1.0X | ||
| read timestamps from files 37481 37517 58 0.3 3748.1 0.1X | ||
| infer timestamps from files 84774 84964 201 0.1 8477.4 0.0X |
dongjoon-hyun
approved these changes
Jul 2, 2020
dongjoon-hyun
left a comment
Member
There was a problem hiding this comment.
+1, LGTM. I checked both places in the benchmark code and test result.
dongjoon-hyun
pushed a commit
that referenced
this pull request
Jul 2, 2020
…mark ### What changes were proposed in this pull request? Set the JSON option `inferTimestamp` to `true` for the cases that measure perf of timestamp inference. ### Why are the changes needed? The PR #28966 disabled timestamp inference by default. As a consequence, some benchmarks don't measure perf of timestamp inference from JSON fields. This PR explicitly enable such inference. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? By re-generating results of `JsonBenchmark`. Closes #28981 from MaxGekk/json-inferTimestamps-disable-by-default-followup. Authored-by: Max Gekk <max.gekk@gmail.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 42f01e3) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Member
|
Merged to master/3.0. This is irrelevant to Jenkins unit tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Set the JSON option
inferTimestamptotruefor the cases that measure perf of timestamp inference.Why are the changes needed?
The PR #28966 disabled timestamp inference by default. As a consequence, some benchmarks don't measure perf of timestamp inference from JSON fields. This PR explicitly enable such inference.
Does this PR introduce any user-facing change?
No
How was this patch tested?
By re-generating results of
JsonBenchmark.