[SPARK-4061][SQL] We cannot use EOL character in the operand of LIKE predicate.

[sarutak]

We cannot use EOL character like \n or \r in the operand of LIKE predicate.
So following condition is never true.

-- someStr is 'hoge\nfuga'
where someStr LIKE 'hoge_fuga'

[SparkQA]

QA tests have started for PR 2908 at commit 38f6651.

• This patch merges cleanly.

[SparkQA]

QA tests have finished for PR 2908 at commit 38f6651.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[liancheng]

I feel a little complicated about this... This function is not on critical path, so I'd like to refactor it in a more functional and arguably more readable (but less efficient) way, for example:

overridedefescape(v: String) ="(?s)"+ (' '+: v.init).zip(v).flatMap {
case (prefix, '_') =>if (prefix =='\\') "_"else"."case (prefix, '%') =>if (prefix =='\\') "%"else".*"case (_, ch) =>Character.toString(ch)
}.mkString

[liancheng]

Good catch! Would you mind to add a unit test for this?

[sarutak]

Thanks @liancheng ! I've refactored and added test cases.

[SparkQA]

Test build #22121 has finished for PR 2908 at commit d98c99e.

• This patch fails Spark unit tests.
• This patch merges cleanly.
• This patch adds no public classes.

[SparkQA]

Test build #22130 has finished for PR 2908 at commit 8a33f91.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[liancheng]

Why do we need this branch?

[liancheng]

Ah, I see, we need to remove leading \\.

[liancheng]

LGTM, thanks for fixing this!

[SparkQA]

Test build #22205 has finished for PR 2908 at commit 1051dd0.

• This patch fails Spark unit tests.
• This patch merges cleanly.
• This patch adds no public classes.

[sarutak]

retest this please.

[SparkQA]

Test build #22214 has finished for PR 2908 at commit 1051dd0.

• This patch fails Spark unit tests.
• This patch merges cleanly.
• This patch adds no public classes.

[sarutak]

retest this please.

[SparkQA]

Test build #22243 has finished for PR 2908 at commit 1051dd0.

• This patch fails Spark unit tests.
• This patch merges cleanly.
• This patch adds no public classes.

[SparkQA]

Test build #22245 has finished for PR 2908 at commit 6bc3318.

• This patch fails Spark unit tests.
• This patch merges cleanly.
• This patch adds no public classes.

[JoshRosen]

It looks like the build configuration for the thriftserver tests may be broken, which is why they're failing:

[error] Expected ID character
[error] Not a valid command: hive-thriftserver
[error] Expected project ID
[error] Expected configuration
[error] Expected ':' (if selecting a configuration)
[error] Expected key
[error] Not a valid key: hive-thriftserver
[error] hive-thriftserver/test
[error] ^
[error] Got a return code of 1 on line 193 of the run-tests script.
Archiving unit tests logs...

[sarutak]

Thanks, I'll try to create another branch from master and then push.

[SparkQA]

Test build #22254 has finished for PR 2908 at commit f99a2f4.

• This patch fails Spark unit tests.
• This patch merges cleanly.
• This patch adds no public classes.

[sarutak]

Ah, I see. It's related to #2950.

[SparkQA]

Test build #453 has finished for PR 2908 at commit f99a2f4.

• This patch fails Spark unit tests.
• This patch merges cleanly.
• This patch adds no public classes.

[SparkQA]

Test build #22260 has finished for PR 2908 at commit d15798b.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[SparkQA]

Test build #464 has finished for PR 2908 at commit d15798b.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[marmbrus]

Thanks for working on this! Merged to master.