Skip to content

[SPARK-32339][ML][DOC] Improve MLlib BLAS native acceleration docs - #29139

Closed
xwu-intel wants to merge 9 commits into
apache:masterfrom
xwu-intel:blas-doc
Closed

[SPARK-32339][ML][DOC] Improve MLlib BLAS native acceleration docs#29139
xwu-intel wants to merge 9 commits into
apache:masterfrom
xwu-intel:blas-doc

Conversation

@xwu-intel

@xwu-intelxwu-intel commented Jul 17, 2020

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

Rewrite a clearer and complete BLAS native acceleration enabling guide.

Why are the changes needed?

The document of enabling BLAS native acceleration in ML guide (https://spark.apache.org/docs/latest/ml-guide.html#dependencies) is incomplete and unclear to the user.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

N/A

@huaxingao

huaxingao commented Jul 17, 2020

Copy link
Copy Markdown
Contributor

cc @srowen@viirya@zhengruifeng

I scanned through. I think the doc is well written and the information is useful.

Here are the screen capture:

before change:
Screen Shot 2020-07-16 at 11 34 44 PM

after change:
Screen Shot 2020-07-16 at 11 34 17 PM
Screen Shot 2020-07-16 at 11 39 09 PM
Screen Shot 2020-07-16 at 11 40 02 PM
Screen Shot 2020-07-16 at 11 40 18 PM

huaxingao
huaxingao reviewed Jul 17, 2020
View reviewed changes
Comment threaddocs/ml-linalg-guide.md Outdated
srowen
srowen requested changes Jul 17, 2020
View reviewed changes
Comment threaddocs/ml-guide.md Outdated
Comment threaddocs/ml-linalg-guide.md Outdated
Comment threaddocs/ml-linalg-guide.md Outdated
Comment threaddocs/ml-linalg-guide.md Outdated
kiszk
kiszk reviewed Jul 19, 2020
View reviewed changes
Comment threaddocs/ml-linalg-guide.md Outdated
kiszk
kiszk reviewed Jul 19, 2020
View reviewed changes
Comment threaddocs/ml-linalg-guide.md Outdated
kiszk
kiszk reviewed Jul 19, 2020
View reviewed changes
Comment threaddocs/ml-linalg-guide.md Outdated
kiszk
kiszk reviewed Jul 19, 2020
View reviewed changes
Comment threaddocs/ml-linalg-guide.md Outdated
kiszk
kiszk reviewed Jul 19, 2020
View reviewed changes
Comment threaddocs/ml-linalg-guide.md Outdated
@xwu-intel

xwu-intel commented Jul 20, 2020

Copy link
Copy Markdown
ContributorAuthor

Fixed based on your comments. Thank you all!

huaxingao
huaxingao reviewed Jul 20, 2020
View reviewed changes
Comment threaddocs/ml-guide.md Outdated
srowen
srowen requested changes Jul 20, 2020
View reviewed changes
Comment threaddocs/ml-linalg-guide.md Outdated
Comment threaddocs/ml-linalg-guide.md Outdated
Comment threaddocs/ml-linalg-guide.md Outdated
Comment threaddocs/ml-linalg-guide.md Outdated
Comment threaddocs/ml-linalg-guide.md Outdated
Comment threaddocs/ml-linalg-guide.md Outdated
viirya
viirya reviewed Jul 21, 2020
View reviewed changes
Comment threaddocs/ml-guide.md Outdated
Comment threaddocs/ml-linalg-guide.md Outdated
@srowen

srowen commented Jul 25, 2020

Copy link
Copy Markdown
Member

Jenkins test this please

@SparkQA

SparkQA commented Jul 25, 2020

Copy link
Copy Markdown

Test build #126549 has finished for PR 29139 at commit 50ada7d.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

huaxingao
huaxingao reviewed Jul 25, 2020
View reviewed changes
Comment threaddocs/ml-linalg-guide.md Outdated
huaxingao
huaxingao reviewed Jul 25, 2020
View reviewed changes
Comment threaddocs/ml-linalg-guide.md Outdated
huaxingao
huaxingao reviewed Jul 25, 2020
View reviewed changes
Comment threaddocs/ml-linalg-guide.md Outdated
@huaxingao

huaxingao commented Jul 27, 2020

Copy link
Copy Markdown
Contributor

LGTM. If nobody has further comments, I will merge this in both 3.0 and master.

huaxingao pushed a commit that referenced this pull request Jul 28, 2020
@xwu-intel@huaxingao
[SPARK-32339][ML][DOC] Improve MLlib BLAS native acceleration docs
8cfb718
### What changes were proposed in this pull request?
Rewrite a clearer and complete BLAS native acceleration enabling guide.
### Why are the changes needed?
The document of enabling BLAS native acceleration in ML guide (https://spark.apache.org/docs/latest/ml-guide.html#dependencies) is incomplete and unclear to the user.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
N/A
Closes#29139 from xwu99/blas-doc.
Lead-authored-by: Xiaochang Wu <xiaochang.wu@intel.com>
Co-authored-by: Wu, Xiaochang <xiaochang.wu@intel.com>
Signed-off-by: Huaxin Gao <huaxing@us.ibm.com>
(cherry picked from commit 44c868b)
Signed-off-by: Huaxin Gao <huaxing@us.ibm.com>
@huaxingao

huaxingao commented Jul 28, 2020

Copy link
Copy Markdown
Contributor

Merged to 3.0/master. Thanks everyone!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@viiryaviiryaviirya left review comments
@kiszkkiszkkiszk left review comments
@huaxingaohuaxingaohuaxingao left review comments
@srowensrowensrowen requested changes

Assignees

No one assigned

Labels

DOCS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@xwu-intel@huaxingao@srowen@SparkQA@viirya@kiszk