[SPARK-32513][SQL] Rename classes/files with the Jdbc prefix to JDBC

[MaxGekk]

What changes were proposed in this pull request?

Replace Jdbc by JDBC in classes and files. I leaved as is JdbcRDD and JdbcDialects because they are a part of semi-public APIs.

Why are the changes needed?

To eliminate inconsistency in naming JDBC files and classes. There are 7 files with the Jdbc prefix:

$ apache-spark git:(master) find . -name "Jdbc*.scala" -type f
./core/src/test/scala/org/apache/spark/rdd/JdbcRDDSuite.scala
./core/src/main/scala/org/apache/spark/rdd/JdbcRDD.scala
./sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtilsSuite.scala
./sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala
./sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcRelationProvider.scala
./sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala
./sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/JdbcConnectionUriSuite.scala

and 8 files start from the JDBC:

$ apache-spark git:(master) find . -name "JDBC*.scala" -type f
./sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala
./sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCWriteSuite.scala
./sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/v2/jdbc/JDBCTableCatalogSuite.scala
./sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala
./sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCOptions.scala
./sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRelation.scala
./sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/jdbc/JDBCTableCatalog.scala
./sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/jdbc/JDBCTable.scala

Does this PR introduce any user-facing change?

Should not.

How was this patch tested?

By existing test suites like JDBCSuite.

[SparkQA]

Test build #126898 has finished for PR 29323 at commit fa2489b.

• This patch fails Spark unit tests.
• This patch merges cleanly.
• This patch adds the following public classes (experimental):
• class JDBCConnectionUriSuite extends HiveThriftServer2Test

[MaxGekk]

@maropu Please, review this PR.

[SparkQA]

Test build #126914 has finished for PR 29323 at commit 7251ba2.

• This patch fails Spark unit tests.
• This patch merges cleanly.
• This patch adds no public classes.

[maropu]

I don't have a strong opinion though, it looks good in terms of naming consistency. cc: @HyukjinKwon

[HyukjinKwon]

Same as @maropu. There's inconsistency in JSON vs Json, CSV vs Csv. Orc might have to be ORC too. The change itself looks fine as one time thing but not sure if we should do it for all. Also, JdbcDialects seems an API that we can't change as well so this PR happened to be unable to address the issues all.

I am going to dismiss my approval since I don't have a strong opinion here.

[dongjoon-hyun]

@MaxGekk . As you see the change on PostgreSQL dialect, this will break the downstream custom dialect. Shall we avoid to change this?

[dongjoon-hyun]

I prefer not to change overall because we cannot be completed in any way after this PR.

I leaved as is JdbcRDD and JdbcDialects because they are a part of semi-public APIs.

Also, this PR can break the downstream 3rd party JDBC driver easily although it's under execution package. As we see, one example is JdbcUtils.scala which already breaks PostgreDialect and this PR needed to adapt from the source code.

After removing JdbcUtils.scala from this PR's scope, we may re-consider this PR again.

BTW, cc @gatorsmile and @cloud-fan .

[maropu]

Ah, I missed that consideration..., thanks, @dongjoon-hyun. As you suggested above, we cannot rename the class names in the main codebase.

[HyukjinKwon]

@dongjoon-hyun, as you said JdbcUtils isn't an API and under the private package. I don't think we should block a PR for this reason. But sure I don't have a strong feeling on this. Let's don't change it for now.

[MaxGekk]

After off-line discussion with @HyukjinKwon, I am closing this PR.