Uh oh!
There was an error while loading. Please reload this page.
[SPARK-32468][SS][TESTS][FOLLOWUP] Provide "default.api.timeout.ms" as well when specifying "request.timeout.ms" on replacing "default.api.timeout.ms" - #29343
Closed
HeartSaVioR wants to merge 1 commit into
Conversation
…s well when specifying "request.timeout.ms" to replace "default.api.timeout.ms"
HeartSaVioR
commented
Aug 4, 2020
ContributorAuthor
Let's make sure Jenkins builds pass multiple times, and Github Action passes. |
HeartSaVioR
commented
Aug 4, 2020
ContributorAuthor
retest this, please |
HeartSaVioR
commented
Aug 4, 2020
ContributorAuthor
cc. @zsxwing as he reviewed #29272 |
HeartSaVioR
commented
Aug 4, 2020
ContributorAuthor
retest this, please |
SparkQA
commented
Aug 4, 2020
Test build #127015 has finished for PR 29343 at commit
|
HeartSaVioR
commented
Aug 4, 2020
ContributorAuthor
retest this, please |
SparkQA
commented
Aug 4, 2020
Test build #127017 has finished for PR 29343 at commit
|
HeartSaVioR
commented
Aug 4, 2020
ContributorAuthor
retest this, please |
HyukjinKwon
commented
Aug 4, 2020
Member
Looks good given the description and explanation. |
HyukjinKwon
commented
Aug 4, 2020
Member
Thanks for working on this @HeartSaVioR. |
SparkQA
commented
Aug 4, 2020
Test build #127018 has finished for PR 29343 at commit
|
SparkQA
commented
Aug 4, 2020
Test build #127020 has finished for PR 29343 at commit
|
HeartSaVioR
commented
Aug 4, 2020
ContributorAuthor
retest this, please |
gaborgsomogyi
commented
Aug 4, 2020
Contributor
Had a look, the explanation and solution makes sense. Thank you guys helping me out! |
HyukjinKwon
commented
Aug 4, 2020
Member
I am going to merge this unblock other PRs. |
HyukjinKwon
commented
Aug 4, 2020
Member
Merged to master. |
HeartSaVioR
commented
Aug 4, 2020
ContributorAuthor
Thanks for the quick reviews & reaction! |
SparkQA
commented
Aug 4, 2020
Test build #127028 has finished for PR 29343 at commit
|
jdcasale pushed a commit
to palantir/spark
that referenced
this pull request
Jun 22, 2021
…s well when specifying "request.timeout.ms" on replacing "default.api.timeout.ms" ### What changes were proposed in this pull request? This patch is a follow-up to fill the gap in apache#29272 which missed to also provide `default.api.timeout.ms` as well. apache#29272 unintentionally changed the behavior on Kafka side timeout which is incompatible with the test timeout. (`default.api.timeout.ms` gets default value which is 60 seconds, longer than test timeout.) ### Why are the changes needed? We realized the PR for SPARK-32468 (apache#29272) doesn't work as we expect. See apache#29272 (comment) for more details. ### Does this PR introduce _any_ user-facing change? No, as it only touches the tests. ### How was this patch tested? Will trigger builds from Jenkins or Github Action multiple time and confirm. Closesapache#29343 from HeartSaVioR/SPARK-32468-FOLLOWUP. Authored-by: Jungtaek Lim (HeartSaVioR) <kabhwan.opensource@gmail.com> Signed-off-by: HyukjinKwon <gurwls223@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This patch is a follow-up to fill the gap in #29272 which missed to also provide
default.api.timeout.msas well. #29272 unintentionally changed the behavior on Kafka side timeout which is incompatible with the test timeout. (default.api.timeout.msgets default value which is 60 seconds, longer than test timeout.)Why are the changes needed?
We realized the PR for SPARK-32468 (#29272) doesn't work as we expect. See #29272 (comment) for more details.
Does this PR introduce any user-facing change?
No, as it only touches the tests.
How was this patch tested?
Will trigger builds from Jenkins or Github Action multiple time and confirm.