Uh oh!
There was an error while loading. Please reload this page.
[SPARK-32524][SQL][TESTS] CachedBatchSerializerSuite should clean up InMemoryRelation.ser - #29346
[SPARK-32524][SQL][TESTS] CachedBatchSerializerSuite should clean up InMemoryRelation.ser#29346dongjoon-hyun wants to merge 3 commits into
Conversation
…InMemoryRelation.ser
dongjoon-hyun
commented
Aug 4, 2020
cc @cloud-fan, @HyukjinKwon , @revans2 , @tgravescs |
HyukjinKwon
left a comment
There was a problem hiding this comment.
LGTM. I prefer this way but don't feel strongly if other people prefer the other way.
Uh oh!
There was an error while loading. Please reload this page.
dongjoon-hyun
commented
Aug 4, 2020
Thank you for reiview and approval, @HyukjinKwon . |
dongjoon-hyun
commented
Aug 4, 2020
Thanks, @cloud-fan . |
SparkQA
commented
Aug 4, 2020
Test build #127030 has finished for PR 29346 at commit
|
SparkQA
commented
Aug 4, 2020
Test build #127033 has finished for PR 29346 at commit
|
SparkQA
commented
Aug 4, 2020
Test build #127032 has finished for PR 29346 at commit
|
cloud-fan
commented
Aug 4, 2020
retest this please |
HyukjinKwon
commented
Aug 4, 2020
I am going to merge this since GitHub Actions builds passed. |
SparkQA
commented
Aug 4, 2020
Test build #127044 has finished for PR 29346 at commit
|
dongjoon-hyun
commented
Aug 4, 2020
Thank you, @cloud-fan and @HyukjinKwon . |
revans2
commented
Aug 4, 2020
Thanks for finding and fixing this for me. |
dongjoon-hyun
commented
Aug 4, 2020
Thanks, @revans2 ! :) |
What changes were proposed in this pull request?
This PR aims to clean up
InMemoryRelation.serinCachedBatchSerializerSuite.Why are the changes needed?
SPARK-32274 makes SQL cache serialization pluggable.
This causes UT failures.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Manually.