Uh oh!
There was an error while loading. Please reload this page.
[SPARK-32686][PYTHON] Un-deprecate inferring DataFrame schema from list of dict - #29510
Closed
nchammas wants to merge 3 commits into
Closed
[SPARK-32686][PYTHON] Un-deprecate inferring DataFrame schema from list of dict#29510nchammas wants to merge 3 commits into
nchammas wants to merge 3 commits into
Conversation
nchammas
commented
Aug 21, 2020
ContributorAuthor
cc @HyukjinKwon |
SparkQA
commented
Aug 21, 2020
Test build #127755 has finished for PR 29510 at commit
|
Uh oh!
There was an error while loading. Please reload this page.
HyukjinKwon
approved these changes
Aug 22, 2020
HyukjinKwon
left a comment
Member
There was a problem hiding this comment.
Looks good assuming from the history:
- Python 2.7's dict does not keep the order, which is fixed in Python 3 and PySpark at SPARK-29748
- It was deprecated when
RowAPI was introduced at 51aa135 in SPARK-2010. I think we now target Python usability and only allowingRowdoesn't look Python friendly.
HyukjinKwon
commented
Aug 22, 2020
Member
cc @BryanCutler fyi |
nchammas
commented
Aug 24, 2020
ContributorAuthor
Yeah, this deprecation has been around for ~6 years. I wonder if we should check with dev@ to make sure there are no surprising consequences of un-deprecating it? |
SparkQA
commented
Aug 24, 2020
Test build #127845 has finished for PR 29510 at commit
|
SparkQA
commented
Aug 24, 2020
Test build #127851 has finished for PR 29510 at commit
|
BryanCutler
commented
Aug 24, 2020
Member
merged to master, thanks @nchammas ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
As discussed in #29491 (comment) and in SPARK-32686, this PR un-deprecates Spark's ability to infer a DataFrame schema from a list of dictionaries. The ability is Pythonic and matches functionality offered by Pandas.
Why are the changes needed?
This change clarifies to users that this behavior is supported and is not going away in the near future.
Does this PR introduce any user-facing change?
Yes. There used to be a
UserWarningfor this, but now there isn't.How was this patch tested?
I tested this manually.
Before:
After: