Uh oh!
There was an error while loading. Please reload this page.
[MINOR][GRAPHX][3.0] Correct typos in the sub-modules: graphx, external, and examples - #30342
[MINOR][GRAPHX][3.0] Correct typos in the sub-modules: graphx, external, and examples#30342jsoref wants to merge 1 commit into
Conversation
…nd examples This PR intends to fix typos in the sub-modules: graphx, external, and examples. Split per holdenk apache#30323 (comment) NOTE: The misspellings have been reported at 706a726#commitcomment-44064356 Misspelled words make it harder to read / understand content. No No testing was performed Closesapache#30326 from jsoref/spelling-graphx. Authored-by: Josh Soref <jsoref@users.noreply.github.com> Signed-off-by: Takeshi Yamamuro <yamamuro@apache.org>
maropu
commented
Nov 12, 2020
ok to test |
SparkQA
commented
Nov 12, 2020
Test build #130951 has finished for PR 30342 at commit
|
SparkQA
commented
Nov 12, 2020
Kubernetes integration test starting |
SparkQA
commented
Nov 12, 2020
Kubernetes integration test status failure |
maropu
commented
Nov 12, 2020
retest this please |
SparkQA
commented
Nov 12, 2020
Kubernetes integration test starting |
SparkQA
commented
Nov 12, 2020
Kubernetes integration test status success |
SparkQA
commented
Nov 12, 2020
Test build #130997 has finished for PR 30342 at commit
|
maropu
commented
Nov 13, 2020
retest this please |
SparkQA
commented
Nov 13, 2020
Kubernetes integration test starting |
SparkQA
commented
Nov 13, 2020
Test build #131039 has finished for PR 30342 at commit
|
SparkQA
commented
Nov 13, 2020
Kubernetes integration test status success |
srowen
commented
Nov 16, 2020
@maropu do you really think we need to backport? that is generally only for bug fixes. It's not a huge deal either way but not sure we should do that in general. |
jsoref
commented
Nov 16, 2020
fwiw, the argument in favor of backporting is that it'll make future backports easier, otherwise any fixes past this point (on master) will be harder to backport (because of the changes made by this work on master). I'm not arguing in favor/opposed (I have no opinion). |
Ah, I see. I thought its better to fix the user-facing typo, so I requested to backport it. But, I don't have a strong feeling on it. We don't need it in branch-3.0, @srowen ? if not, we need to revert it in branch-2.4. |
srowen
commented
Nov 17, 2020
Oh I see, already in 2.4. OK go ahead and merge it rather than revert. I don't feel strongly either, just know we don't generally backport anything like this as a rule. |
maropu
commented
Nov 17, 2020
ok~, thanks for the check, @srowen |
maropu
commented
Nov 17, 2020
retest this please |
SparkQA
commented
Nov 17, 2020
Kubernetes integration test starting |
SparkQA
commented
Nov 17, 2020
Kubernetes integration test status failure |
SparkQA
commented
Nov 17, 2020
Test build #131185 has finished for PR 30342 at commit
|
…al, and examples ### What changes were proposed in this pull request? This PR intends to fix typos in the sub-modules: graphx, external, and examples. Split per holdenk #30323 (comment) NOTE: The misspellings have been reported at jsoref@706a726#commitcomment-44064356 Backport of #30326 ### Why are the changes needed? Misspelled words make it harder to read / understand content. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? No testing was performed Closes#30342 from jsoref/branch-3.0-30326. Authored-by: Josh Soref <jsoref@users.noreply.github.com> Signed-off-by: Takeshi Yamamuro <yamamuro@apache.org>
maropu
commented
Nov 17, 2020
Thanks! Merged to branch-3.0. |
What changes were proposed in this pull request?
This PR intends to fix typos in the sub-modules: graphx, external, and examples.
Split per @holdenk#30323 (comment)
NOTE: The misspellings have been reported at jsoref@706a726#commitcomment-44064356
Backport of #30326
Why are the changes needed?
Misspelled words make it harder to read / understand content.
Does this PR introduce any user-facing change?
No
How was this patch tested?
No testing was performed