[SPARK-33503][SQL] Refactor SortOrder class to allow multiple childrens

[prakharjain09]

What changes were proposed in this pull request?

This is a followup of #30302 . As part of this PR, sameOrderExpressions set is made part of children of SortOrder node - so that they don't need any special handling as done in #30302 .

Why are the changes needed?

sameOrderExpressions should get same treatment as child. So making them part of children helps in transforming them easily.

Does this PR introduce any user-facing change?

No

How was this patch tested?

Existing UTs

[prakharjain09]

@cloud-fan@maropu I have made the changes as suggested in #30302 (comment) .

[HyukjinKwon]

ok to test

[maropu]

@prakharjain09 Thanks for working on this. btw, could you assign a new jira ID to this?

[maropu]

We need to use Set for this variable?

[prakharjain09]

The set property of this variable is used at couple of places in SortMergeJoin (here, here).

We can use ExpressionSet maybe at those 2 places and make it a Seq in constructor here. any thoughts?

[maropu]

We can use ExpressionSet maybe at those 2 places and make it a Seq in constructor here. any thoughts?

Yea, I think it is okay to just deduplicate it before storing it in the class as you said, and then make it Seq.

[SparkQA]

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35990/

[SparkQA]

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35990/

[SparkQA]

Test build #131386 has finished for PR 30430 at commit f3a8ded.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[SparkQA]

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36032/

[SparkQA]

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36032/

[SparkQA]

Test build #131426 has finished for PR 30430 at commit 9510b5f.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[SparkQA]

Test build #131785 has finished for PR 30430 at commit 1c38e97.

• This patch fails PySpark unit tests.
• This patch merges cleanly.
• This patch adds no public classes.

[SparkQA]

Test build #131885 has finished for PR 30430 at commit b82540e.

• This patch fails Spark unit tests.
• This patch merges cleanly.
• This patch adds no public classes.

[SparkQA]

Test build #131886 has finished for PR 30430 at commit 815396e.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds the following public classes (experimental):
• case class UnixTimestamp(
• case class SerdeInfo(
• case class FormatClasses(input: String, output: String)
• case class CoalesceShufflePartitions(session: SparkSession) extends CustomShuffleReaderRule
• trait CustomShuffleReaderRule extends Rule[SparkPlan]

[maropu]

The GA tests passed, so I merged to master. Thanks!