Uh oh!
There was an error while loading. Please reload this page.
[SPARK-33621][SQL] Add a way to inject data source rewrite rules - #30577
[SPARK-33621][SQL] Add a way to inject data source rewrite rules#30577aokolnychyi wants to merge 2 commits into
Conversation
aokolnychyi
commented
Dec 2, 2020
aokolnychyi
commented
Dec 2, 2020
We should probably wait for clarity on the discussion here before moving on with this one. |
dongjoon-hyun
commented
Dec 2, 2020
cc @gatorsmile |
rdblue
commented
Dec 2, 2020
This looks good to me, but I agree that we should change the name if anyone comes up with a better one. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
SparkQA
commented
Dec 3, 2020
Test build #132072 has finished for PR 30577 at commit
|
aokolnychyi
commented
Dec 3, 2020
I'll wait to update this until we resolve the name issue. |
dongjoon-hyun
commented
Dec 3, 2020
@aokolnychyi . Could you address the existing comments first without waiting for the others? They are orthogonal. You don't need to wait. For example,
|
aokolnychyi
commented
Dec 4, 2020
Will do today, @dongjoon-hyun! |
dongjoon-hyun
commented
Dec 6, 2020
Gentle ping, @aokolnychyi .
|
| @@ -199,6 +199,21 @@ class SparkSessionExtensions { | |||
| optimizerRules += builder | |||
| } | |||
There was a problem hiding this comment.
Could you update the description above, too?
There was a problem hiding this comment.
Done, thanks for catching this!
aokolnychyi
commented
Dec 7, 2020
Sorry for the delay, @dongjoon-hyun! I've updated the PR now. |
aokolnychyi
commented
Dec 7, 2020
Gentle ping @gatorsmile on the name suggestion discussed here. |
SparkQA
commented
Dec 7, 2020
Kubernetes integration test starting |
SparkQA
commented
Dec 7, 2020
Kubernetes integration test status success |
SparkQA
commented
Dec 7, 2020
Test build #132361 has finished for PR 30577 at commit
|
aokolnychyi
commented
Dec 7, 2020
Test failures are in |
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thank you for updating, @aokolnychyi .
Merged to master for Apache Spark 3.2.0.
What changes were proposed in this pull request?
This PR adds a way to inject data source rewrite rules.
Why are the changes needed?
Right now
SparkSessionExtensionsallow us to inject optimization rules but they are added to operator optimization batch. There are cases when users need to run rules after the operator optimization batch (e.g. cases when a rule relies on the fact that expressions have been optimized). Currently, this is not possible.Does this PR introduce any user-facing change?
Yes.
How was this patch tested?
This PR comes with a new test.