Skip to content

[SPARK-4211][Build] Fixes hive.version in Maven profile hive-0.13.1 - #3072

Closed
coderfi wants to merge 1 commit into
apache:masterfrom
coderfi:master
Closed

[SPARK-4211][Build] Fixes hive.version in Maven profile hive-0.13.1#3072
coderfi wants to merge 1 commit into
apache:masterfrom
coderfi:master

Conversation

@coderfi

@coderficoderfi commented Nov 3, 2014

Copy link
Copy Markdown
Contributor

Simple pom.xml update.

@coderfi
Fixes the hive-0.13.1 maven profile referencing hive.version=0.13.1
7ca4b1e
instead of the Spark compatible `hive.version=0.13.1a`
Note: `hive.version=0.13.1a` is the default version.
However, when explicitly specifying the `hive-0.13.1` maven profile, the
wrong one would be selected.
e.g. mvn -Phive -Phive=0.13.1
See PR #2685
@AmplabJenkins

AmplabJenkins commented Nov 3, 2014

Copy link
Copy Markdown

Can one of the admins verify this patch?

@coderficoderfi mentioned this pull request Nov 3, 2014
Closed
@liancheng

liancheng commented Nov 3, 2014

Copy link
Copy Markdown
Contributor

test this please

@SparkQA

SparkQA commented Nov 3, 2014

Copy link
Copy Markdown

Test build #22809 has started for PR 3072 at commit 7ca4b1e.

  • This patch merges cleanly.

@SparkQA

SparkQA commented Nov 3, 2014

Copy link
Copy Markdown

Test build #22809 has finished for PR 3072 at commit 7ca4b1e.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins

AmplabJenkins commented Nov 3, 2014

Copy link
Copy Markdown

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/22809/
Test PASSed.

@liancheng

liancheng commented Nov 3, 2014

Copy link
Copy Markdown
Contributor

@coderfi Would you please file a JIRA ticket for this and then rename the title of this PR to something like "[SPARK-9999][Build] Fixes hive.version in Maven profile hive-0.13.1"?

@liancheng

liancheng commented Nov 3, 2014

Copy link
Copy Markdown
Contributor

This LGTM besides PR title and the missing JIRA ticket. Thanks!

@coderfi

coderfi commented Nov 3, 2014

Copy link
Copy Markdown
ContributorAuthor

Hello,

I'll file a ticket.
Suggestion on the title?oops, didn't see your above note

Fi
On Nov 3, 2014 2:09 AM, "Cheng Lian" notifications@github.com wrote:

This LGTM besides PR title and the missing JIRA ticket. Thanks!

—
Reply to this email directly or view it on GitHub
#3072 (comment).

@coderficoderfi changed the title The hive-0.13.1 maven profile now sets hive.version=0.13.1a[SPARK-4211][Build] Fixes hive.version in Maven profile hive-0.13.1Nov 3, 2014
@pwendell

pwendell commented Nov 3, 2014

Copy link
Copy Markdown
Contributor

LGTM

@marmbrus

marmbrus commented Nov 3, 2014

Copy link
Copy Markdown
Contributor

Thanks! Merged to master.

asfgit pushed a commit that referenced this pull request Nov 3, 2014
@coderfi@marmbrus
[SPARK-4211][Build] Fixes hive.version in Maven profile hive-0.13.1
fc78289
instead of `hive.version=0.13.1`.
e.g. mvn -Phive -Phive=0.13.1
Note: `hive.version=0.13.1a` is the default property value. However, when explicitly specifying the `hive-0.13.1` maven profile, the wrong one would be selected.
References: PR #2685, which resolved a package incompatibility issue with Hive-0.13.1 by introducing a special version Hive-0.13.1a
Author: fi <coderfi@gmail.com>
Closes#3072 from coderfi/master and squashes the following commits:
7ca4b1e [fi] Fixes the `hive-0.13.1` maven profile referencing `hive.version=0.13.1` instead of the Spark compatible `hive.version=0.13.1a` Note: `hive.version=0.13.1a` is the default version. However, when explicitly specifying the `hive-0.13.1` maven profile, the wrong one would be selected. e.g. mvn -Phive -Phive=0.13.1 See PR #2685
(cherry picked from commit df607da)
Signed-off-by: Michael Armbrust <michael@databricks.com>
@asfgitasfgit closed this in df607daNov 3, 2014
@coderfi

coderfi commented Nov 3, 2014

Copy link
Copy Markdown
ContributorAuthor

Glad to be of service. :)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@coderfi@AmplabJenkins@liancheng@SparkQA@pwendell@marmbrus