Uh oh!
There was an error while loading. Please reload this page.
[MINOR][SQL] Fix the comment for CalendarIntervalType about comparability. - #31610
Closed
MaxGekk wants to merge 1 commit into
Closed
[MINOR][SQL] Fix the comment for CalendarIntervalType about comparability.#31610MaxGekk wants to merge 1 commit into
MaxGekk wants to merge 1 commit into
Conversation
MaxGekk
commented
Feb 22, 2021
MemberAuthor
@yaooqinn@cloud-fan Could you take a look at this minor fix. |
yaooqinn
commented
Feb 22, 2021
Member
LGTM |
yaooqinn
approved these changes
Feb 22, 2021
cloud-fan
commented
Feb 22, 2021
Contributor
thanks, merging to master/3.1! |
cloud-fan pushed a commit
that referenced
this pull request
Feb 22, 2021
…lity ### What changes were proposed in this pull request? In the PR, I propose to revert #26659 partially regarding to comparability of interval values. The comment became incorrect after #27262. ### Why are the changes needed? The comment is incorrect, and it might confuse Spark's devs/users. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? By checking scala coding style `./dev/scalastyle`. Closes#31610 from MaxGekk/doc-interval-not-comparable. Authored-by: Max Gekk <max.gekk@gmail.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com> (cherry picked from commit 7df4fed) Signed-off-by: Wenchen Fan <wenchen@databricks.com>
SparkQA
commented
Feb 22, 2021
Test build #135342 has finished for PR 31610 at commit
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In the PR, I propose to revert #26659 partially regarding to comparability of interval values. The comment became incorrect after #27262.
Why are the changes needed?
The comment is incorrect, and it might confuse Spark's devs/users.
Does this PR introduce any user-facing change?
No
How was this patch tested?
By checking scala coding style
./dev/scalastyle.