[SPARK-34856][FOLLOWUP][SQL] Remove dead code from AnsiCast.typeCheckFailureMessage

[gengliangwang]

What changes were proposed in this pull request?

After #31954, Array type is allowed to be cast as String type. So the customized conversion failure message branch from AnsiCast.typeCheckFailureMessage won't be reached anymore.
This PR is to remove the dead code.

Why are the changes needed?

Code clean up.

Does this PR introduce any user-facing change?

No

How was this patch tested?

Just removing dead code.

[SparkQA]

Kubernetes integration test unable to build dist.

exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41300/

[gengliangwang]

retest this please.

[gengliangwang]

^^^ I haven't sent this jenkins command for months...Have to do it since GA is slow now.

[MaxGekk]

LGTM, I wonder don't we have any test for the "dead" code?

[gengliangwang]

I wonder don't we have any test for the "dead" code?

@MaxGekk The error message of casting array type to string is not checked in #30260. Sorry about that.

[SparkQA]

Kubernetes integration test unable to build dist.

exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41310/

[SparkQA]

Test build #136718 has finished for PR 32004 at commit 93fea67.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[srowen]

Merged to master

[SparkQA]

Test build #136729 has finished for PR 32004 at commit 93fea67.

• This patch fails Spark unit tests.
• This patch merges cleanly.
• This patch adds no public classes.