Uh oh!
There was an error while loading. Please reload this page.
[SPARK-34716][SQL] Support ANSI SQL intervals by the aggregate function sum - #32107
Closed
beliefer wants to merge 9 commits into
Closed
[SPARK-34716][SQL] Support ANSI SQL intervals by the aggregate function sum#32107beliefer wants to merge 9 commits into
sum#32107beliefer wants to merge 9 commits into
Conversation
Loading
Uh oh!
There was an error while loading. Please reload this page.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Extend the
Sumexpression to to supportDayTimeIntervalTypeandYearMonthIntervalTypeadded by #31614.Note: the expressions can throw the overflow exception independently from the SQL config
spark.sql.ansi.enabled. In this way, the modified expressions always behave in the ANSI mode for the intervals.Why are the changes needed?
Extend
org.apache.spark.sql.catalyst.expressions.aggregate.Sumto supportDayTimeIntervalTypeandYearMonthIntervalType.Does this PR introduce any user-facing change?
'No'.
Should not since new types have not been released yet.
How was this patch tested?
Jenkins test