Skip to content

[SPARK-31225][SQL][2.4] Override sql method of OuterReference - #32256

Closed
yaooqinn wants to merge 3 commits into
apache:branch-2.4from
yaooqinn:SPARK-31225
Closed

[SPARK-31225][SQL][2.4] Override sql method of OuterReference#32256
yaooqinn wants to merge 3 commits into
apache:branch-2.4from
yaooqinn:SPARK-31225

Conversation

@yaooqinn

@yaooqinnyaooqinn commented Apr 20, 2021

Copy link
Copy Markdown
Member

What changes were proposed in this pull request?

Per #32179 (comment) 's request to backport SPARK-31225 to branch 2.4

Why are the changes needed?

Does this PR introduce any user-facing change?

How was this patch tested?

@yaooqinn

yaooqinn commented Apr 20, 2021

Copy link
Copy Markdown
MemberAuthor

cc @cloud-fan@viirya thanks

@HyukjinKwon

HyukjinKwon commented Apr 20, 2021

Copy link
Copy Markdown
Member

Once Jenkins build passes, it should be good to go.

@SparkQA

SparkQA commented Apr 20, 2021

Copy link
Copy Markdown

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42216/

@SparkQA

SparkQA commented Apr 20, 2021

Copy link
Copy Markdown

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42216/

cloud-fan
cloud-fan approved these changes Apr 20, 2021
View reviewed changes

@cloud-fancloud-fan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if tests pass

@SparkQA

SparkQA commented Apr 20, 2021

Copy link
Copy Markdown

Test build #137689 has finished for PR 32256 at commit d887e74.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@viirya

viirya commented Apr 20, 2021

Copy link
Copy Markdown
Member

Can you fix the error message?

viirya
viirya approved these changes Apr 20, 2021
View reviewed changes

@viiryaviirya left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. we just need to update the error message in the failed test.

@SparkQA

SparkQA commented Apr 20, 2021

Copy link
Copy Markdown

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42225/

@SparkQA

SparkQA commented Apr 20, 2021

Copy link
Copy Markdown

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42225/

@SparkQA

SparkQA commented Apr 20, 2021

Copy link
Copy Markdown

Test build #137698 has finished for PR 32256 at commit 5e945b4.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@viirya

viirya commented Apr 20, 2021

Copy link
Copy Markdown
Member

Seems there is still other error?

@SparkQA

SparkQA commented Apr 21, 2021

Copy link
Copy Markdown

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42240/

@SparkQA

SparkQA commented Apr 21, 2021

Copy link
Copy Markdown

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42240/

@SparkQA

SparkQA commented Apr 21, 2021

Copy link
Copy Markdown

Test build #137712 has finished for PR 32256 at commit a4681c3.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@cloud-fan

cloud-fan commented Apr 21, 2021

Copy link
Copy Markdown
Contributor

thanks, merging to 2.4!

@viirya

viirya commented Apr 21, 2021

Copy link
Copy Markdown
Member

Thanks! Merging to 2.4.

cloud-fan pushed a commit that referenced this pull request Apr 21, 2021
@yaooqinn@cloud-fan
[SPARK-31225][SQL][2.4] Override sql method of OuterReference
1630d64
### What changes were proposed in this pull request?
Per #32179 (comment) 's request to backport SPARK-31225 to branch 2.4
### Why are the changes needed?
### Does this PR introduce _any_ user-facing change?
### How was this patch tested?
Closes#32256 from yaooqinn/SPARK-31225.
Authored-by: Kent Yao <yao@apache.org>
Signed-off-by: Wenchen Fan <wenchen@databricks.com>
@yaooqinn
yaooqinn deleted the SPARK-31225 branch April 21, 2021 07:35
@viiryaviirya mentioned this pull request Apr 21, 2021
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@viiryaviiryaviirya approved these changes
@cloud-fancloud-fancloud-fan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@yaooqinn@HyukjinKwon@SparkQA@viirya@cloud-fan