Skip to content

[SPARK-35142][PYTHON][ML][3.0] Fix incorrect return type for rawPredictionUDF in OneVsRestModel - #32275

Closed
harupy wants to merge 1 commit into
apache:branch-3.0from
harupy:backport-35142-3.0
Closed

[SPARK-35142][PYTHON][ML][3.0] Fix incorrect return type for rawPredictionUDF in OneVsRestModel#32275
harupy wants to merge 1 commit into
apache:branch-3.0from
harupy:backport-35142-3.0

Conversation

@harupy

@harupyharupy commented Apr 21, 2021•
edited
Loading

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

This PR backports #32245.

Fixes incorrect return type for rawPredictionUDF in OneVsRestModel.

Why are the changes needed?

Bugfix

Does this PR introduce any user-facing change?

No

How was this patch tested?

Unit test.

@harupyharupy changed the title [SPARK-35142][PYTHON][ML][3.0] Fix incorrect return type for rawPredictionUDF in OneVsRestModel[SPARK-35142][PYTHON][ML][3.0] Fix incorrect return type for rawPredictionUDF in OneVsRestModelApr 21, 2021
HyukjinKwon
HyukjinKwon approved these changes Apr 21, 2021
View reviewed changes

@HyukjinKwonHyukjinKwon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if tests pass

@SparkQA

SparkQA commented Apr 21, 2021

Copy link
Copy Markdown

Test build #137735 has finished for PR 32275 at commit 1e84817.

  • This patch fails to build.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA

SparkQA commented Apr 21, 2021

Copy link
Copy Markdown

Kubernetes integration test unable to build dist.

exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42262/

Yikun
Yikun approved these changes Apr 21, 2021
View reviewed changes

@YikunYikun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and the CI failed is unrelated.

@HyukjinKwon

HyukjinKwon commented Apr 22, 2021

Copy link
Copy Markdown
Member

retest this please

@SparkQA

SparkQA commented Apr 22, 2021

Copy link
Copy Markdown

Kubernetes integration test unable to build dist.

exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42285/

@SparkQA

SparkQA commented Apr 22, 2021

Copy link
Copy Markdown

Test build #137758 has finished for PR 32275 at commit 1e84817.

  • This patch fails to build.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen

srowen commented Apr 23, 2021

Copy link
Copy Markdown
Member

Jenkins retest this please

@SparkQA

SparkQA commented Apr 23, 2021

Copy link
Copy Markdown

Test build #137870 has finished for PR 32275 at commit 1e84817.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA

SparkQA commented Apr 23, 2021

Copy link
Copy Markdown

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42400/

@SparkQA

SparkQA commented Apr 23, 2021

Copy link
Copy Markdown

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42400/

dongjoon-hyun
dongjoon-hyun approved these changes Apr 24, 2021
View reviewed changes

@dongjoon-hyundongjoon-hyun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. Thank you, @harupy and all.
Merged to branch-3.0.

dongjoon-hyun pushed a commit that referenced this pull request Apr 24, 2021
@harupy@dongjoon-hyun
[SPARK-35142][PYTHON][ML][3.0] Fix incorrect return type for `rawPred…
4c79e10
…ictionUDF` in `OneVsRestModel`
### What changes were proposed in this pull request?
This PR backports #32245.
Fixes incorrect return type for `rawPredictionUDF` in `OneVsRestModel`.
### Why are the changes needed?
Bugfix
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Unit test.
Closes#32275 from harupy/backport-35142-3.0.
Authored-by: harupy <17039389+harupy@users.noreply.github.com>
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
@dongjoon-hyun

dongjoon-hyun commented Apr 24, 2021

Copy link
Copy Markdown
Member

I added you to the Apache Spark contributor group and SPARK-35142 is assigned to you.
Thank you for your first contribution, @harupy . Welcome!

@harupy

harupy commented Apr 25, 2021

Copy link
Copy Markdown
ContributorAuthor

@dongjoon-hyun Thanks!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@YikunYikunYikun approved these changes
@HyukjinKwonHyukjinKwonHyukjinKwon approved these changes
@dongjoon-hyundongjoon-hyundongjoon-hyun approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@harupy@SparkQA@HyukjinKwon@srowen@dongjoon-hyun@Yikun