Uh oh!
There was an error while loading. Please reload this page.
[SPARK-33298][CORE][FOLLOWUP] Add Unstable annotation to FileCommitProtocol - #33148
Closed
c21 wants to merge 3 commits into
Closed
[SPARK-33298][CORE][FOLLOWUP] Add Unstable annotation to FileCommitProtocol#33148c21 wants to merge 3 commits into
FileCommitProtocol#33148c21 wants to merge 3 commits into
Conversation
c21
commented
Jun 30, 2021
ContributorAuthor
cc @HyukjinKwon and @cloud-fan please take a look when you have time, thanks. |
Uh oh!
There was an error while loading. Please reload this page.
HyukjinKwon
approved these changes
Jun 30, 2021
FileCommitProtocolFileCommitProtocolUh oh!
There was an error while loading. Please reload this page.
dongjoon-hyun
approved these changes
Jun 30, 2021
SparkQA
commented
Jun 30, 2021
Kubernetes integration test starting |
SparkQA
commented
Jun 30, 2021
Kubernetes integration test status success |
HyukjinKwon
commented
Jun 30, 2021
Member
Merged to master. |
SparkQA
commented
Jun 30, 2021
Test build #140424 has finished for PR 33148 at commit
|
c21
commented
Jun 30, 2021
ContributorAuthor
Thank you @HyukjinKwon and @dongjoon-hyun for review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is the followup from #33012 (comment), where we want to add
@UnstabletoFileCommitProtocol, to give people a better idea of API.Why are the changes needed?
Make it easier for people to follow and understand code. Clean up code.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing unit tests, as no real logic change.