Uh oh!
There was an error while loading. Please reload this page.
[SPARK-35829][SQL][FOLLOWUP] Use subExprCode to avoid duplicate call of addNewFunction - #33305
Closed
viirya wants to merge 1 commit into
Closed
[SPARK-35829][SQL][FOLLOWUP] Use subExprCode to avoid duplicate call of addNewFunction#33305viirya wants to merge 1 commit into
viirya wants to merge 1 commit into
Conversation
viirya
commented
Jul 12, 2021
MemberAuthor
cc @cloud-fan |
SparkQA
commented
Jul 12, 2021
Kubernetes integration test starting |
SparkQA
commented
Jul 12, 2021
Kubernetes integration test status success |
SparkQA
commented
Jul 12, 2021
Test build #140932 has finished for PR 33305 at commit
|
viirya
commented
Jul 13, 2021
MemberAuthor
maropu
reviewed
Jul 13, 2021
| // at least two nodes) as the cost of doing it is expected to be low. | ||
| val subExprCode = s"${addNewFunction(fnName, fn)}($INPUT_ROW);" | ||
| subexprFunctions += s"${addNewFunction(fnName, fn)}($INPUT_ROW);" |
MemberAuthor
There was a problem hiding this comment.
addNewFunction will overwrite in the method map. So this won't add new function. But it is better to avoid duplicatie call.
maropu
approved these changes
Jul 13, 2021
viirya
commented
Jul 13, 2021
MemberAuthor
Thanks @maropu. Merging to master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
A followup of #32980. We should use
subExprCodeto avoid duplicate call ofaddNewFunction.Why are the changes needed?
Avoid duplicate all of
addNewFunction.Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing test.