Uh oh!
There was an error while loading. Please reload this page.
[SPARK-36702][SQL] ArrayUnion handle duplicated Double.NaN and Float.Nan - #33951
[SPARK-36702][SQL] ArrayUnion handle duplicated Double.NaN and Float.Nan#33951AngersZhuuuu wants to merge 2 commits into
Conversation
AngersZhuuuu
commented
Sep 10, 2021
ping @cloud-fan |
SparkQA
commented
Sep 10, 2021
Kubernetes integration test starting |
SparkQA
commented
Sep 10, 2021
Kubernetes integration test starting |
SparkQA
commented
Sep 10, 2021
Kubernetes integration test status failure |
SparkQA
commented
Sep 10, 2021
Kubernetes integration test status failure |
SparkQA
commented
Sep 10, 2021
Test build #143136 has finished for PR 33951 at commit
|
SparkQA
commented
Sep 10, 2021
Test build #143137 has finished for PR 33951 at commit
|
srowen
commented
Sep 11, 2021
How does this differ from #33955 ? |
AngersZhuuuu
commented
Sep 12, 2021
HyukjinKwon
commented
Sep 12, 2021
Mind elabourating #33951 (comment)? Also let's keep one PR only for the issue if we're clear on which approach to go ahead for. |
Close this, you can go ahead on that pr. |
What changes were proposed in this pull request?
For query
This returns [NaN, NaN], but it should return [NaN].
This issue is caused by
OpenHashSetcan't handleDouble.NaNandFloat.NaNtoo.In this pr we handle
NaNlikeNullvalueWhy are the changes needed?
Fix bug
Does this PR introduce any user-facing change?
ArrayUnion won't show duplicated
NaNvalueHow was this patch tested?
Added UT