[SPARK-36921][SQL] Support ANSI intervals by DIV

[Peng-Lei]

What changes were proposed in this pull request?

1. support div(YearMonthIntervalType, YearMonthIntervalType), return long result
2. support div(DayTimeIntervalType, DayTimeIntervalType), return long result
3. if input is NULL or input2 is 0, then return null

Why are the changes needed?

Extended the div function to support ANSI intervals. The operation should produce quotient of division.
SPARK-36921

Does this PR introduce any user-facing change?

Yes, user can use user can use YearMonthIntervalType and DayTimeIntervalType as input for div function.

How was this patch tested?

Add ut testcase

[Peng-Lei]

@MaxGekk Could you take a look? Thank you. I'm not quite sure if this PR will solve the SPARK-36921

[MaxGekk]

ok to test

[MaxGekk]

@Peng-Lei Could you add a couple of end-to-end tests to intervals.sql including a negative test:

SELECT DIV(INTERVAL '1' MONTH, INTERVAL '1' DAY);

[SparkQA]

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48638/

[SparkQA]

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48638/

[MaxGekk]

Could you check negative intervals, and also some corner cases like division by max/min and zero intervals (ArithmeticExpressionSuite).

[MaxGekk]

LGTM in general, could you add an example to the expression description.

[SparkQA]

Test build #144160 has finished for PR 34257 at commit a593010.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[SparkQA]

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48670/

[SparkQA]

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48670/

[MaxGekk]

+1, LGTM. Merging to master.
Thank you, @Peng-Lei .

[SparkQA]

Test build #144191 has finished for PR 34257 at commit 1f3459b.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[cloud-fan]

1. why do we pick long as the result type? any reference?
2. why we return null for divide by 0, instead of failing?

[MaxGekk]

@cloud-fan The ANSI SQL standard doesn't define the semantic of DIV. We can implement it as we want.

why do we pick long as the result type?

For the consistency to existing Spark's DIV implementation for other input types. This is widest integer that doesn't overflow on div of day-time interval.

[MaxGekk]

Why DIV returns long is the question to you, @cloud-fan ;-)
#22395 (comment)

[MaxGekk]

why we return null for divide by 0, instead of failing?

Following to our current approach for ANSI interval in other places, we should be more stronger here. @Peng-Lei Could you address this, please.