Uh oh!
There was an error while loading. Please reload this page.
[SPARK-37050][PYTHON] Update Conda installation instructions - #34315
[SPARK-37050][PYTHON] Update Conda installation instructions#34315h-vetinari wants to merge 5 commits into
Conversation
gengliangwang
commented
Oct 18, 2021
@h-vetinari Thanks for the first contribution! Could you file a Jira ticket on https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=256 and follow the PR template? |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
HyukjinKwon
commented
Oct 19, 2021
ok to test |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
HyukjinKwon
commented
Oct 19, 2021
@srowen, when you find some time, can you help reviewing this please 🙏 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
HyukjinKwon
left a comment
There was a problem hiding this comment.
Looks pretty good otherwise - made some minor suggestions. Thanks for your PR @h-vetinari.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
HyukjinKwon
commented
Oct 21, 2021
Jenkins, ok to test |
SparkQA
commented
Oct 21, 2021
Test build #144481 has finished for PR 34315 at commit
|
SparkQA
commented
Oct 21, 2021
Kubernetes integration test starting |
SparkQA
commented
Oct 21, 2021
Kubernetes integration test status failure |
Co-authored-by: Hyukjin Kwon <gurwls223@gmail.com>
HyukjinKwon
commented
Oct 21, 2021
will merge this one in few more days if there are no more comments. |
h-vetinari
commented
Oct 21, 2021
Sounds good, thanks for the review! Are you planning to merge to the 3.2 branch as well? I think that would be worth a consideration given that the online docs would otherwise keep reflecting the old instructions until 3.3, which is going to take a while yet... |
SparkQA
commented
Oct 21, 2021
Test build #144486 has finished for PR 34315 at commit
|
HyukjinKwon
commented
Oct 21, 2021
I think we can backport to branch-3.2 but that won't be available on Spark 3.2.0 as it's already released. So i will probably just merge it to master branch for now. |
SparkQA
commented
Oct 21, 2021
Kubernetes integration test starting |
h-vetinari
commented
Oct 21, 2021
Well, 3.2.1 will presumably still arrive much sooner than 3.3.0, and then the most current docs would also be updated along with it, no? |
HyukjinKwon
commented
Oct 21, 2021
Might be faster a couple of months, and improvement doesn't usually go to maintenance release by right. |
srowen
commented
Oct 21, 2021
A docs change like this seems ok to backport to 3.2 imho |
SparkQA
commented
Oct 21, 2021
Kubernetes integration test status failure |
HyukjinKwon
commented
Oct 21, 2021
Just wanted to more just point out the standard practice. I am good with that too for extra clarification. |
h-vetinari
commented
Oct 21, 2021
Thanks both, glad to hear it! :) |
gengliangwang
left a comment
There was a problem hiding this comment.
Thanks for the update. +1 to backport to the 3.2 documentation site.
HyukjinKwon
commented
Oct 22, 2021
Merged to master and branch-3.2. |
### What changes were proposed in this pull request? Improve conda installation docs ### Why are the changes needed? As requested [here](apache/spark-website#361 (comment)). Ideally, this should be backported to the 3.2-branch (so it becomes visible for the 3.2.0 installation documentation [here](https://spark.apache.org/docs/3.2.0/api/python/getting_started/install.html)). CC gengliangwang ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Not tested Closes#34315 from h-vetinari/conda-install. Lead-authored-by: H. Vetinari <h.vetinari@gmx.com> Co-authored-by: h-vetinari <h.vetinari@gmx.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org> (cherry picked from commit 016ab0c) Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
### What changes were proposed in this pull request? Improve conda installation docs ### Why are the changes needed? As requested [here](apache/spark-website#361 (comment)). Ideally, this should be backported to the 3.2-branch (so it becomes visible for the 3.2.0 installation documentation [here](https://spark.apache.org/docs/3.2.0/api/python/getting_started/install.html)). CC gengliangwang ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Not tested Closesapache#34315 from h-vetinari/conda-install. Lead-authored-by: H. Vetinari <h.vetinari@gmx.com> Co-authored-by: h-vetinari <h.vetinari@gmx.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org> (cherry picked from commit 016ab0c) Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
### What changes were proposed in this pull request? Improve conda installation docs ### Why are the changes needed? As requested [here](apache/spark-website#361 (comment)). Ideally, this should be backported to the 3.2-branch (so it becomes visible for the 3.2.0 installation documentation [here](https://spark.apache.org/docs/3.2.0/api/python/getting_started/install.html)). CC gengliangwang ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Not tested Closesapache#34315 from h-vetinari/conda-install. Lead-authored-by: H. Vetinari <h.vetinari@gmx.com> Co-authored-by: h-vetinari <h.vetinari@gmx.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org> (cherry picked from commit 016ab0c) Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
### What changes were proposed in this pull request? Improve conda installation docs ### Why are the changes needed? As requested [here](apache/spark-website#361 (comment)). Ideally, this should be backported to the 3.2-branch (so it becomes visible for the 3.2.0 installation documentation [here](https://spark.apache.org/docs/3.2.0/api/python/getting_started/install.html)). CC gengliangwang ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Not tested Closesapache#34315 from h-vetinari/conda-install. Lead-authored-by: H. Vetinari <h.vetinari@gmx.com> Co-authored-by: h-vetinari <h.vetinari@gmx.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org> (cherry picked from commit 016ab0c) Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
What changes were proposed in this pull request?
Improve conda installation docs
Why are the changes needed?
As requested here. Ideally, this should be backported to the 3.2-branch (so it becomes visible for the 3.2.0 installation documentation here).
CC @gengliangwang
Does this PR introduce any user-facing change?
No
How was this patch tested?
Not tested