Uh oh!
There was an error while loading. Please reload this page.
[SPARK-37060][CORE] Handle driver status response from backup masters - #34331
[SPARK-37060][CORE] Handle driver status response from backup masters#34331testsgmr wants to merge 1 commit into
Conversation
AmplabJenkins
commented
Oct 19, 2021
Can one of the admins verify this patch? |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Ngone51
commented
Nov 12, 2021
srowen
left a comment
There was a problem hiding this comment.
I don't know enough to review this. Can you CC the author of the change before this?
testsgmr
commented
Nov 17, 2021
Could someone please review these changes? CC: @cloud-fan@Ngone51@HeartSaVioR@jiangxb1987 |
Uh oh!
There was an error while loading. Please reload this page.
Ngone51
commented
Dec 14, 2021
@mohamadrezarostami you may need to rebase your branch to pass GA. |
…sponse from backup masters
testsgmr
commented
Dec 15, 2021
Done! |
Ngone51
commented
Dec 15, 2021
Thanks, merged to master. @mohamadrezarostami Could you create PRs to backport this to branch-3.2/branch-3.1? |
testsgmr
commented
Dec 15, 2021
@Ngone51 |
What changes were proposed in this pull request?
After an improvement in SPARK-31486, contributor uses 'asyncSendToMasterAndForwardReply' method instead of 'activeMasterEndpoint.askSync' to get the status of driver. Since the driver's status is only available in active master and the 'asyncSendToMasterAndForwardReply' method iterate over all of the masters, we have to handle the response from the backup masters in the client, which the developer did not consider in the SPARK-31486 change. So drivers running in cluster mode and on a cluster with multi masters affected by this bug.
Why are the changes needed?
We need to find if the response received from a backup master client must ignore it.
Does this PR introduce any user-facing change?
No, It's only fixed a bug and brings back the ability to deploy in cluster mode on multi-master clusters.
How was this patch tested?