Uh oh!
There was an error while loading. Please reload this page.
[SPARK-1434] [MLLIB] change labelParser from anonymous function to trait - #345
[SPARK-1434] [MLLIB] change labelParser from anonymous function to trait#345mengxr wants to merge 5 commits into
Conversation
AmplabJenkins
commented
Apr 7, 2014
Merged build triggered. |
AmplabJenkins
commented
Apr 7, 2014
Merged build started. |
AmplabJenkins
commented
Apr 7, 2014
Merged build finished. |
AmplabJenkins
commented
Apr 7, 2014
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13845/ |
AmplabJenkins
commented
Apr 7, 2014
Merged build triggered. |
AmplabJenkins
commented
Apr 7, 2014
Merged build started. |
There was a problem hiding this comment.
Maybe call this parse instead of apply, should be friendlier
manishamde
commented
Apr 7, 2014
@mengxr Since I can't find the comment where you mentioned me (probably deleted), I believe you don't need my review on this. :-) |
AmplabJenkins
commented
Apr 7, 2014
Merged build finished. |
AmplabJenkins
commented
Apr 7, 2014
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13852/ |
use extends for singleton
AmplabJenkins
commented
Apr 7, 2014
Merged build triggered. |
AmplabJenkins
commented
Apr 7, 2014
Merged build started. |
mengxr
commented
Apr 7, 2014
@manishamde Sorry! I sent my comment to the wrong PR. You already found the right one ~ :) |
AmplabJenkins
commented
Apr 7, 2014
Merged build finished. |
AmplabJenkins
commented
Apr 7, 2014
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13855/ |
support distributing extra files to worker for yarn client mode So that user doesn't need to package all dependency into one assemble jar as spark app jar
mengxr
commented
Apr 8, 2014
Jenkins, retest this please. |
AmplabJenkins
commented
Apr 8, 2014
Merged build triggered. |
AmplabJenkins
commented
Apr 8, 2014
Merged build started. |
AmplabJenkins
commented
Apr 8, 2014
Merged build finished. All automated tests passed. |
AmplabJenkins
commented
Apr 8, 2014
All automated tests passed. |
AmplabJenkins
commented
Apr 8, 2014
Merged build triggered. |
AmplabJenkins
commented
Apr 8, 2014
Merged build started. |
AmplabJenkins
commented
Apr 8, 2014
Merged build finished. All automated tests passed. |
AmplabJenkins
commented
Apr 8, 2014
All automated tests passed. |
AmplabJenkins
commented
Apr 8, 2014
Merged build triggered. |
AmplabJenkins
commented
Apr 8, 2014
Merged build started. |
AmplabJenkins
commented
Apr 8, 2014
Merged build finished. All automated tests passed. |
AmplabJenkins
commented
Apr 8, 2014
All automated tests passed. |
pwendell
commented
Apr 9, 2014
Thanks, merged. |
This is a patch to address @mateiz 's comment in apache#245 MLUtils#loadLibSVMData uses an anonymous function for the label parser. Java users won't like it. So I make a trait for LabelParser and provide two implementations: binary and multiclass. Author: Xiangrui Meng <meng@databricks.com> Closesapache#345 from mengxr/label-parser and squashes the following commits: ac44409 [Xiangrui Meng] use singleton objects for label parsers 3b1a7c6 [Xiangrui Meng] add tests for label parsers c2e571c [Xiangrui Meng] rename LabelParser.apply to LabelParser.parse use extends for singleton 11c94e0 [Xiangrui Meng] add return types 7f8eb36 [Xiangrui Meng] change labelParser from annoymous function to trait
* Add manageiq-providers-openstack job for public clouds
This is a patch to address @mateiz 's comment in #245
MLUtils#loadLibSVMData uses an anonymous function for the label parser. Java users won't like it. So I make a trait for LabelParser and provide two implementations: binary and multiclass.