Skip to content

[SPARK-4604][MLLIB] make MatrixFactorizationModel public - #3459

Closed
mengxr wants to merge 3 commits into
apache:masterfrom
mengxr:SPARK-4604
Closed

[SPARK-4604][MLLIB] make MatrixFactorizationModel public#3459
mengxr wants to merge 3 commits into
apache:masterfrom
mengxr:SPARK-4604

Conversation

@mengxr

@mengxrmengxr commented Nov 25, 2014

Copy link
Copy Markdown
Contributor

User could construct an MF model directly. I added a note about the performance.

@SparkQA

SparkQA commented Nov 25, 2014

Copy link
Copy Markdown

Test build #23845 has started for PR 3459 at commit a624c12.

  • This patch merges cleanly.

@SparkQA

SparkQA commented Nov 25, 2014

Copy link
Copy Markdown

Test build #23845 has finished for PR 3459 at commit a624c12.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class MatrixFactorizationModel(

@AmplabJenkins

AmplabJenkins commented Nov 25, 2014

Copy link
Copy Markdown

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23845/
Test PASSed.

jkbradley
jkbradley reviewed Nov 25, 2014
View reviewed changes
Comment threadmllib/src/main/scala/org/apache/spark/mllib/recommendation/MatrixFactorizationModel.scala Outdated

@jkbradleyjkbradleyNov 25, 2014

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does "NB" mean?

@srowensrowenNov 26, 2014

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NB = "Nota Bene", just "note well"

@SparkQA

SparkQA commented Nov 26, 2014

Copy link
Copy Markdown

Test build #23855 has started for PR 3459 at commit ed08214.

  • This patch merges cleanly.

jkbradley
jkbradley reviewed Nov 26, 2014
View reviewed changes
Comment threadmllib/src/test/scala/org/apache/spark/mllib/recommendation/MatrixFactorizationModelSuite.scala Outdated

@jkbradleyjkbradleyNov 26, 2014

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Organize imports

@jkbradley

jkbradley commented Nov 26, 2014

Copy link
Copy Markdown
Member

@mengxr Except for the imports, LGTM

@SparkQA

SparkQA commented Nov 26, 2014

Copy link
Copy Markdown

Test build #23860 has started for PR 3459 at commit f64bcd3.

  • This patch merges cleanly.

@SparkQA

SparkQA commented Nov 26, 2014

Copy link
Copy Markdown

Test build #23855 has finished for PR 3459 at commit ed08214.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class MatrixFactorizationModel(

@AmplabJenkins

AmplabJenkins commented Nov 26, 2014

Copy link
Copy Markdown

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23855/
Test PASSed.

@SparkQA

SparkQA commented Nov 26, 2014

Copy link
Copy Markdown

Test build #23860 has finished for PR 3459 at commit f64bcd3.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class MatrixFactorizationModel(

@AmplabJenkins

AmplabJenkins commented Nov 26, 2014

Copy link
Copy Markdown

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23860/
Test PASSed.

@mengxr

mengxr commented Nov 26, 2014

Copy link
Copy Markdown
ContributorAuthor

@jkbradley Thanks! I've merged this into master and branch-1.2.

mengxr added a commit to mengxr/spark that referenced this pull request Nov 26, 2014
@mengxr
[SPARK-4604][MLLIB] make MatrixFactorizationModel public
2756d0d
User could construct an MF model directly. I added a note about the performance.
Author: Xiangrui Meng <meng@databricks.com>
Closesapache#3459 from mengxr/SPARK-4604 and squashes the following commits:
f64bcd3 [Xiangrui Meng] organize imports
ed08214 [Xiangrui Meng] check preconditions and unit tests
a624c12 [Xiangrui Meng] make MatrixFactorizationModel public
(cherry picked from commit b5fb141)
Signed-off-by: Xiangrui Meng <meng@databricks.com>
mengxr added a commit to mengxr/spark that referenced this pull request Nov 26, 2014
@mengxr
[SPARK-4604][MLLIB] make MatrixFactorizationModel public
b749000
User could construct an MF model directly. I added a note about the performance.
Author: Xiangrui Meng <meng@databricks.com>
Closesapache#3459 from mengxr/SPARK-4604 and squashes the following commits:
f64bcd3 [Xiangrui Meng] organize imports
ed08214 [Xiangrui Meng] check preconditions and unit tests
a624c12 [Xiangrui Meng] make MatrixFactorizationModel public
(cherry picked from commit b5fb141)
Signed-off-by: Xiangrui Meng <meng@databricks.com>
@mengxrmengxr mentioned this pull request Nov 26, 2014
Closed
asfgit pushed a commit that referenced this pull request Nov 26, 2014
@mengxr
[BRANCH-1.2][SPARK-4604][MLLIB] make MatrixFactorizationModel public
9b63900
We reverted #3459 in branch-1.2 due to missing `import o.a.s.SparkContext._`, which is no longer needed in master (#3262). This PR adds #3459 back to branch-1.2 with correct imports.
Github is out-of-sync now. The real changes are the last two commits.
Author: Xiangrui Meng <meng@databricks.com>
Closes#3473 from mengxr/SPARK-4604-1.2 and squashes the following commits:
a7638a5 [Xiangrui Meng] add import o.a.s.SparkContext._ for v1.2
b749000 [Xiangrui Meng] [SPARK-4604][MLLIB] make MatrixFactorizationModel public
@zsxwingzsxwing mentioned this pull request Dec 3, 2016
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mengxr@SparkQA@AmplabJenkins@jkbradley@srowen