Skip to content

[SPARK-4397][Core] Cleanup 'import SparkContext._' in core - #3530

Closed
zsxwing wants to merge 1 commit into
apache:masterfrom
zsxwing:SPARK-4397-cleanup
Closed

[SPARK-4397][Core] Cleanup 'import SparkContext._' in core#3530
zsxwing wants to merge 1 commit into
apache:masterfrom
zsxwing:SPARK-4397-cleanup

Conversation

@zsxwing

Copy link
Copy Markdown
Member

This PR cleans up import SparkContext._ in core for SPARK-4397(#3262) to prove it really works well.

@SparkQA

Copy link
Copy Markdown

Test build #23977 has started for PR 3530 at commit 04e2273.

  • This patch merges cleanly.

@JoshRosen

Copy link
Copy Markdown
Contributor

This is a really important fix, actually, since we ran into problems with IntelliJ's automatic import cleanup removing these: if we perform this import cleanup incrementally as part of other patches, then those patches will introduce build-breaks if they're cherry-picked into pre-1.2 versions of Spark. As a result, it's much better to do all of this cleanup in one pass, as you've done here.

+1.

@SparkQA

Copy link
Copy Markdown

Test build #23977 has finished for PR 3530 at commit 04e2273.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins

Copy link
Copy Markdown

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23977/
Test PASSed.

@rxin

rxin commented Dec 2, 2014

Copy link
Copy Markdown
Contributor

Thanks. Merging in master.

@asfgitasfgit closed this in 6dfe38aDec 2, 2014
@zsxwing
zsxwing deleted the SPARK-4397-cleanup branch December 2, 2014 08:20
@zzcclp

Copy link
Copy Markdown
Contributor

Whether this PR will be merged into the branch 1.2?

@zsxwing

Copy link
Copy Markdown
MemberAuthor

No. This is for SPARK-4397(#3262) and #3262 wasn't merged to branch 1.2.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@zsxwing@SparkQA@JoshRosen@AmplabJenkins@rxin@zzcclp