Skip to content

[SPARK-37145][K8S][FOLLOWUP] Add note for KubernetesCustom[Driver/Executor]FeatureConfigStep - #35496

Closed
Yikun wants to merge 4 commits into
apache:masterfrom
Yikun:SPARK-37145-followup
Closed

[SPARK-37145][K8S][FOLLOWUP] Add note for KubernetesCustom[Driver/Executor]FeatureConfigStep#35496
Yikun wants to merge 4 commits into
apache:masterfrom
Yikun:SPARK-37145-followup

Conversation

@Yikun

@YikunYikun commented Feb 12, 2022•
edited
Loading

Copy link
Copy Markdown
Member

What changes were proposed in this pull request?

Add note for developers to show how to use KubernetesDriverCustomFeatureConfigStep and KubernetesExecutorCustomFeatureConfigStep (#35345).

Why are the changes needed?

Give an example to show how to use it.

Does this PR introduce any user-facing change?

No, doc only

How was this patch tested?

ci passed

HyukjinKwon
HyukjinKwon reviewed Feb 12, 2022
View reviewed changes
Comment thread...ain/scala/org/apache/spark/deploy/k8s/features/KubernetesDriverCustomFeatureConfigStep.scala Outdated
Comment thread...ain/scala/org/apache/spark/deploy/k8s/features/KubernetesDriverCustomFeatureConfigStep.scala Outdated
Comment thread...ain/scala/org/apache/spark/deploy/k8s/features/KubernetesDriverCustomFeatureConfigStep.scala
Comment thread...ain/scala/org/apache/spark/deploy/k8s/features/KubernetesDriverCustomFeatureConfigStep.scala Outdated
@HyukjinKwon

HyukjinKwon commented Feb 13, 2022

Copy link
Copy Markdown
Member

Looking fine but let me cc @dongjoon-hyun@attilapiros FYI

@YikunYikun changed the title [SPARK-37145][K8S][FOLLOWUP] Add note for KubernetesDriverCustomFeatureConfigStep[SPARK-37145][K8S][FOLLOWUP] Add note for KubernetesCustom[Driver/Executor]FeatureConfigStepFeb 13, 2022
@dongjoon-hyundongjoon-hyun changed the title [SPARK-37145][K8S][FOLLOWUP] Add note for KubernetesCustom[Driver/Executor]FeatureConfigStep[SPARK-37145][K8S][FOLLOWUP] Add note for KubernetesCustom[Driver/Executor]FeatureConfigStepFeb 14, 2022
@dongjoon-hyun

dongjoon-hyun commented Feb 14, 2022

Copy link
Copy Markdown
Member

Thank you for pinging me, @HyukjinKwon .

dongjoon-hyun
dongjoon-hyun requested changes Feb 14, 2022
View reviewed changes

@dongjoon-hyundongjoon-hyun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about the advertising of this ambiguous example naming ExecutorExampleFeatureStep. Since this is a document, we had better choose a better guideline for the name which will serve for both driver and executor.

@Yikun

Yikun commented Feb 14, 2022

Copy link
Copy Markdown
MemberAuthor

I'm not sure about the advertising of this ambiguous example naming ExecutorExampleFeatureStep. Since this is a document, we had better choose a better guideline for the name which will serve for both driver and executor.

Maybe DriverAndExecutorExampleFeatureStep ?

@dongjoon-hyun

dongjoon-hyun commented Feb 14, 2022

Copy link
Copy Markdown
Member

Thanks. That looks better, @Yikun .

@dongjoon-hyun

dongjoon-hyun commented Feb 16, 2022

Copy link
Copy Markdown
Member

Gentle ping, @Yikun .

@Yikun

Yikun commented Feb 16, 2022

Copy link
Copy Markdown
MemberAuthor

@dongjoon-hyun addressed! : )

dongjoon-hyun
dongjoon-hyun approved these changes Feb 16, 2022
View reviewed changes

@dongjoon-hyundongjoon-hyun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. Merged to master.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@attilapirosattilapirosattilapiros left review comments
@HyukjinKwonHyukjinKwonHyukjinKwon left review comments
@dongjoon-hyundongjoon-hyundongjoon-hyun approved these changes

Assignees

No one assigned

Labels

KUBERNETES

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Yikun@HyukjinKwon@dongjoon-hyun@attilapiros