Uh oh!
There was an error while loading. Please reload this page.
[SPARK-4692] [SQL] Support ! boolean logic operator like NOT - #3555
[SPARK-4692] [SQL] Support ! boolean logic operator like NOT#3555YanTangZhai wants to merge 23 commits into
Conversation
SparkQA
commented
Dec 2, 2014
Test build #24041 has started for PR 3555 at commit
|
SparkQA
commented
Dec 2, 2014
Test build #24041 has finished for PR 3555 at commit
|
AmplabJenkins
commented
Dec 2, 2014
Test PASSed. |
marmbrus
commented
Dec 2, 2014
Please add a test to |
SparkQA
commented
Dec 3, 2014
Test build #24070 has started for PR 3555 at commit
|
SparkQA
commented
Dec 3, 2014
Test build #24070 has finished for PR 3555 at commit
|
AmplabJenkins
commented
Dec 3, 2014
Test FAILed. |
SparkQA
commented
Dec 3, 2014
Test build #24076 has started for PR 3555 at commit
|
SparkQA
commented
Dec 3, 2014
Test build #24076 has finished for PR 3555 at commit
|
AmplabJenkins
commented
Dec 3, 2014
Test PASSed. |
marmbrus
commented
Dec 11, 2014
Do other SQL dialects support this? I think we should avoid too much non-standard syntax. |
marmbrus
commented
Dec 17, 2014
How about we switch this to a query test (YanTangZhai#14). otherwise LGTM |
Use createQueryTest
SparkQA
commented
Dec 18, 2014
Test build #24583 has started for PR 3555 at commit
|
SparkQA
commented
Dec 18, 2014
Test build #24583 has finished for PR 3555 at commit
|
AmplabJenkins
commented
Dec 18, 2014
Test PASSed. |
YanTangZhai
commented
Dec 18, 2014
@marmbrus Please review again. Thanks. |
AmplabJenkins
commented
Dec 22, 2014
Test FAILed. |
liancheng
commented
Dec 22, 2014
Ah, sorry, forgot that the golden answer file name is generated by the MD5 of the query string. Then let's revert the last space change. I think this minor issue doesn't worth the trouble. Sorry for the inconvenience... |
YanTangZhai
commented
Dec 22, 2014
@liancheng I will revert the last space change. Thanks for your comment. |
SparkQA
commented
Dec 22, 2014
Test build #24702 has started for PR 3555 at commit
|
SparkQA
commented
Dec 22, 2014
Test build #24702 has finished for PR 3555 at commit
|
AmplabJenkins
commented
Dec 22, 2014
Test PASSed. |
liancheng
commented
Dec 22, 2014
Thanks for the update, this now LGTM. |
marmbrus
commented
Dec 30, 2014
Hey sorry, this has merge conflicts. Can you merge with master? |
SparkQA
commented
Dec 31, 2014
Test build #24935 has started for PR 3555 at commit
|
SparkQA
commented
Dec 31, 2014
Test build #24939 has started for PR 3555 at commit
|
SparkQA
commented
Dec 31, 2014
Test build #24940 has started for PR 3555 at commit
|
SparkQA
commented
Dec 31, 2014
Test build #24935 has finished for PR 3555 at commit
|
AmplabJenkins
commented
Dec 31, 2014
Test PASSed. |
YanTangZhai
commented
Dec 31, 2014
@marmbrus I've updated it. Please review again. |
SparkQA
commented
Dec 31, 2014
Test build #24939 has finished for PR 3555 at commit
|
AmplabJenkins
commented
Dec 31, 2014
Test PASSed. |
SparkQA
commented
Dec 31, 2014
Test build #24940 has finished for PR 3555 at commit
|
AmplabJenkins
commented
Dec 31, 2014
Test PASSed. |
marmbrus
commented
Jan 10, 2015
Thanks! I've merged this to master. |
Support ! boolean logic operator like NOT in sql as follows
select * from for_test where !(col1 > col2)