Skip to content

[SPARK-38278][PYTHON] Add SparkContext.addArchive in PySpark - #35603

Closed
HyukjinKwon wants to merge 2 commits into
apache:masterfrom
HyukjinKwon:python-addArchive
Closed

[SPARK-38278][PYTHON] Add SparkContext.addArchive in PySpark#35603
HyukjinKwon wants to merge 2 commits into
apache:masterfrom
HyukjinKwon:python-addArchive

Conversation

@HyukjinKwon

Copy link
Copy Markdown
Member

What changes were proposed in this pull request?

This PR proposes to add SparkContext.addArchive in PySpark side that's added in #30486.

Why are the changes needed?

To have the same API parity with the Scala side.

Does this PR introduce any user-facing change?

Yes, this PR exposes an API (SparkContext.addArchive) that exists in Scala side.

How was this patch tested?

Doctest was added.

@HyukjinKwon

Copy link
Copy Markdown
MemberAuthor

cc @sarutak mind taking a look when you find some time?

Comment threadpython/pyspark/context.py Outdated
Comment threadpython/pyspark/context.py Outdated
@sarutak

Copy link
Copy Markdown
Member

@HyukjinKwon Thank you for adding this feature for Python!
I think it almost LGTM except for some minor stuffs.

@sarutaksarutak left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Pending GA.

@sarutak

Copy link
Copy Markdown
Member

Merging to master. Thank you @HyukjinKwon and @Yikun !

@HyukjinKwon

Copy link
Copy Markdown
MemberAuthor

Thanks!!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@HyukjinKwon@sarutak@Yikun