Uh oh!
There was an error while loading. Please reload this page.
Remove extra semicolon in import statement and unused import in ApplicationMaster - #358
Remove extra semicolon in import statement and unused import in ApplicationMaster#358hsaputra wants to merge 1 commit into
Conversation
rxin
commented
Apr 8, 2014
bothers me too. will merge once jenkins is happy. |
AmplabJenkins
commented
Apr 8, 2014
Merged build triggered. |
AmplabJenkins
commented
Apr 8, 2014
Merged build started. |
srowen
commented
Apr 8, 2014
Meta question - all of the unused imports can be zapped in one go with an IDE and semicolons too. Is that worth one big PR here? |
rxin
commented
Apr 8, 2014
It might be worth it. But be careful sometimes IDE gives you false signals. Also for the imports to conform to Spark's coding standard, we need @aarondav's import organizer plugin for IntelliJ. |
hsaputra
commented
Apr 8, 2014
@srowen there has been PR (I think I sent it) to remove unnecessary semicolons and imports in Scala before and AFAIK we have removed most of them. Probably the best way to have some kind of check executed by Jenkins in addition to style check. |
AmplabJenkins
commented
Apr 8, 2014
Merged build finished. |
AmplabJenkins
commented
Apr 8, 2014
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13882/ |
hsaputra
commented
Apr 8, 2014
Seems like Jenkins had build error related to some PySpark file parsing. |
rxin
commented
Apr 8, 2014
Jenkins, retest this please. |
AmplabJenkins
commented
Apr 8, 2014
Merged build triggered. |
AmplabJenkins
commented
Apr 8, 2014
Merged build started. |
AmplabJenkins
commented
Apr 8, 2014
Merged build finished. All automated tests passed. |
AmplabJenkins
commented
Apr 8, 2014
All automated tests passed. |
rxin
commented
Apr 8, 2014
ok i've merged this. thanks |
hsaputra
commented
Apr 8, 2014
Thx! |
…cationMaster Small nit cleanup to remove extra semicolon and unused import in Yarn's stable ApplicationMaster (it bothers me every time I saw it) Author: Henry Saputra <hsaputra@apache.org> Closesapache#358 from hsaputra/nitcleanup_removesemicolon_import_applicationmaster and squashes the following commits: bffb685 [Henry Saputra] Remove extra semicolon in import statement and unused import in ApplicationMaster.scala
* Fix manageiq job against Mitaka devstack
…e#358) * KY-895, Spark driver pod cleanup when application is completed * KY-895, release 3.1.1-kylin-4.x-r42-xuanwu
…#528) * KY-895, Spark driver pod cleanup when application is completed (apache#358) * KY-895, Spark driver pod cleanup when application is completed * KY-895, release 3.1.1-kylin-4.x-r42-xuanwu * KY-895, add config KUBERNETES_DELETE_DRIVER (apache#376) Co-authored-by: Feng Zhu <fishcus@outlook.com>
* KE-39980 configMap Binds the KE pod * minor fix dockerfile java version and host user (apache#510) * KY-895 Spark driver pod cleanup when application is completed (apache#528) * KY-895, Spark driver pod cleanup when application is completed (apache#358) * KY-895, Spark driver pod cleanup when application is completed * KY-895, release 3.1.1-kylin-4.x-r42-xuanwu * KY-895, add config KUBERNETES_DELETE_DRIVER (apache#376) Co-authored-by: Feng Zhu <fishcus@outlook.com> --------- Co-authored-by: Jiawei Li <jiawei.li@kyligence.io> Co-authored-by: Zhiting Guo <35057824+frearb@users.noreply.github.com> Co-authored-by: Feng Zhu <fishcus@outlook.com>
Small nit cleanup to remove extra semicolon and unused import in Yarn's stable ApplicationMaster (it bothers me every time I saw it)