Skip to content

[SPARK-38566][SQL][3.3] Revert the parser changes for DEFAULT column support - #35885

Closed
MaxGekk wants to merge 1 commit into
apache:branch-3.3from
MaxGekk:revert-default-column-support-3.3
Closed

[SPARK-38566][SQL][3.3] Revert the parser changes for DEFAULT column support#35885
MaxGekk wants to merge 1 commit into
apache:branch-3.3from
MaxGekk:revert-default-column-support-3.3

Conversation

@MaxGekk

@MaxGekk MaxGekk commented Mar 17, 2022

Copy link
Copy Markdown
Member

What changes were proposed in this pull request?

Revert the commit e21cb62 from branch-3.3.

Why are the changes needed?

See discussion in the PR #35690.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

By existing test suites.

@MaxGekk

MaxGekk commented Mar 17, 2022

Copy link
Copy Markdown
Member Author

@HyukjinKwon This is the PR created from scratch, but still GAs are not triggered.

@dongjoon-hyun dongjoon-hyun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. Thank you, @MaxGekk . Pending CI.

I'm also not sure about the reason why the CI is not triggered here.

@dongjoon-hyun

Copy link
Copy Markdown
Member

cc @dtenedor and @gengliangwang , too

@gengliangwang

Copy link
Copy Markdown
Member

Actually having this in 3.3 can return a better error message if users are running queries with column default.
I am fine with either way, keep it or revert it. It's up to @MaxGekk

@dongjoon-hyun

Copy link
Copy Markdown
Member

We agreed on reverting already, @gengliangwang . :)

@MaxGekk

MaxGekk commented Mar 17, 2022

Copy link
Copy Markdown
Member Author

@gengliangwang FYI, GAs haven't been triggered yet.

@gengliangwang

Copy link
Copy Markdown
Member

@dongjoon-hyun Yes
@MaxGekk yes I found it and deleted my comment :)

@HyukjinKwon

Copy link
Copy Markdown
Member

It's passed at https://github.com/MaxGekk/spark/runs/5581819136?check_suite_focus=true so we can merge it anyway

@HyukjinKwon

Copy link
Copy Markdown
Member

Will make a fix soon.

@MaxGekk

MaxGekk commented Mar 17, 2022

Copy link
Copy Markdown
Member Author

Merging to branch-3.3. Thank you, @gengliangwang @dongjoon-hyun and @HyukjinKwon for review.

MaxGekk added a commit that referenced this pull request Mar 17, 2022
…support

### What changes were proposed in this pull request?
Revert the commit e21cb62 from `branch-3.3`.

### Why are the changes needed?
See discussion in the PR #35690.

### Does this PR introduce _any_ user-facing change?
No.

### How was this patch tested?
By existing test suites.

Closes #35885 from MaxGekk/revert-default-column-support-3.3.

Authored-by: Max Gekk <max.gekk@gmail.com>
Signed-off-by: Max Gekk <max.gekk@gmail.com>
@MaxGekk MaxGekk closed this Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants