Uh oh!
There was an error while loading. Please reload this page.
[SPARK-39272][SQL][3.3] Increase the start position of query context by 1 - #36684
Closed
gengliangwang wants to merge 1 commit into
Closed
[SPARK-39272][SQL][3.3] Increase the start position of query context by 1#36684gengliangwang wants to merge 1 commit into
gengliangwang wants to merge 1 commit into
Conversation
Increase the start position of query context by 1 Currently, the line number starts from 1, while the start position starts from 0. Thus it's better to increase the start position by 1 for consistency. No UT Closesapache#36651 from gengliangwang/increase1. Authored-by: Gengliang Wang <gengliang@apache.org> Signed-off-by: Gengliang Wang <gengliang@apache.org>
gengliangwang
commented
May 26, 2022
MemberAuthor
This is to port #36651 to branch-3.3 |
cloud-fan
approved these changes
May 26, 2022
yaooqinn
approved these changes
May 26, 2022
MaxGekk
approved these changes
May 26, 2022
gengliangwang
commented
May 26, 2022
MemberAuthor
Merging to 3.3 |
gengliangwang added a commit
that referenced
this pull request
May 26, 2022
…by 1 ### What changes were proposed in this pull request? Increase the start position of query context by 1 ### Why are the changes needed? Currently, the line number starts from 1, while the start position starts from 0. Thus it's better to increase the start position by 1 for consistency. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? UT Closes#36684 from gengliangwang/portSPARK-39234. Authored-by: Gengliang Wang <gengliang@apache.org> Signed-off-by: Gengliang Wang <gengliang@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Increase the start position of query context by 1
Why are the changes needed?
Currently, the line number starts from 1, while the start position starts from 0.
Thus it's better to increase the start position by 1 for consistency.
Does this PR introduce any user-facing change?
No
How was this patch tested?
UT