Uh oh!
There was an error while loading. Please reload this page.
[SPARK-39259][SQL][3.3] Evaluate timestamps consistently in subqueries - #36752
Closed
olaky wants to merge 1 commit into
Closed
[SPARK-39259][SQL][3.3] Evaluate timestamps consistently in subqueries#36752olaky wants to merge 1 commit into
olaky wants to merge 1 commit into
Conversation
AmplabJenkins
commented
Jun 3, 2022
Can one of the admins verify this patch? |
MaxGekk
commented
Jun 3, 2022
Member
+1, LGTM. Merging to 3.3. |
MaxGekk pushed a commit
that referenced
this pull request
Jun 3, 2022
### What changes were proposed in this pull request? Apply the optimizer rule ComputeCurrentTime consistently across subqueries. This is a backport of #36654. ### Why are the changes needed? At the moment timestamp functions like now() can return different values within a query if subqueries are involved ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? A new unit test was added Closes#36752 from olaky/SPARK-39259-spark_3_3. Authored-by: Ole Sasse <ole.sasse@databricks.com> Signed-off-by: Max Gekk <max.gekk@gmail.com>
olaky
commented
Jun 3, 2022
ContributorAuthor
Thanks for picking this up so quickly, I wanted to first see if the build passes and then update the comment |
dongjoon-hyun
commented
Jun 3, 2022
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Apply the optimizer rule ComputeCurrentTime consistently across subqueries.
This is a backport of #36654.
Why are the changes needed?
At the moment timestamp functions like now() can return different values within a query if subqueries are involved
Does this PR introduce any user-facing change?
No
How was this patch tested?
A new unit test was added