Skip to content

[SPARK-4837] NettyBlockTransferService should use spark.blockManager.port config - #3688

Closed
aarondav wants to merge 1 commit into
apache:masterfrom
aarondav:SPARK-4837
Closed

[SPARK-4837] NettyBlockTransferService should use spark.blockManager.port config#3688
aarondav wants to merge 1 commit into
apache:masterfrom
aarondav:SPARK-4837

Conversation

@aarondav

Copy link
Copy Markdown
Contributor

@SparkQA

Copy link
Copy Markdown

Test build #24430 has started for PR 3688 at commit ebd2007.

  • This patch merges cleanly.

@SparkQA

Copy link
Copy Markdown

Test build #24430 has finished for PR 3688 at commit ebd2007.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins

Copy link
Copy Markdown

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24430/
Test FAILed.

@aarondav

Copy link
Copy Markdown
ContributorAuthor

Jenkins, retest this please.

@SparkQA

Copy link
Copy Markdown

Test build #24441 has started for PR 3688 at commit ebd2007.

  • This patch merges cleanly.

@SparkQA

Copy link
Copy Markdown

Test build #24441 has finished for PR 3688 at commit ebd2007.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins

Copy link
Copy Markdown

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24441/
Test FAILed.

@rxin

rxin commented Dec 16, 2014

Copy link
Copy Markdown
Contributor

Jenkins, retest this please.

@SparkQA

Copy link
Copy Markdown

Test build #24503 has started for PR 3688 at commit ebd2007.

  • This patch merges cleanly.

@SparkQA

Copy link
Copy Markdown

Test build #24503 has finished for PR 3688 at commit ebd2007.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins

Copy link
Copy Markdown

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24503/
Test PASSed.

@rxin

rxin commented Dec 16, 2014

Copy link
Copy Markdown
Contributor

LGTM.

@JoshRosen

Copy link
Copy Markdown
Contributor

LGTM, too, so I'm going to merge this into master (1.3.0) and branch-1.2 (1.2.1). Thanks!

asfgit pushed a commit that referenced this pull request Dec 19, 2014
…port config
This is used in NioBlockTransferService here:
https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/network/nio/NioBlockTransferService.scala#L66
Author: Aaron Davidson <aaron@databricks.com>
Closes#3688 from aarondav/SPARK-4837 and squashes the following commits:
ebd2007 [Aaron Davidson] [SPARK-4837] NettyBlockTransferService should use spark.blockManager.port config
(cherry picked from commit 105293a)
Signed-off-by: Josh Rosen <joshrosen@databricks.com>
@dizzy2

Copy link
Copy Markdown

this fix doesn't work when both executor and driver are running on the same machine (as they are trying to acquire the same port)

@aarondav

Copy link
Copy Markdown
ContributorAuthor

@dizzy2 Sorry, thought I responded earlier -- you are quite right. It should be a straightforward fix of adding a Utils.startServiceOnPort call to do the same incrementing we do elsewhere.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@aarondav@SparkQA@AmplabJenkins@rxin@JoshRosen@dizzy2