Skip to content

[SPARK-40098][SQL][FOLLOWUP] Revert the pretty format of error messages in the Thrift Server - #37773

Closed
MaxGekk wants to merge 1 commit into
apache:masterfrom
MaxGekk:thrift-serv-json-errors-followup
Closed

[SPARK-40098][SQL][FOLLOWUP] Revert the pretty format of error messages in the Thrift Server#37773
MaxGekk wants to merge 1 commit into
apache:masterfrom
MaxGekk:thrift-serv-json-errors-followup

Conversation

@MaxGekk

Copy link
Copy Markdown
Member

What changes were proposed in this pull request?

In the PR, I propose:

  1. Output errors in the PRETTY format in the same way as before the PR [SPARK-40098][SQL] Format error messages in the Thrift Server #37520.
  2. Do not output non-JSON elements in the MINIMAL and STANDARD formats.

Why are the changes needed?

  1. To not break existing apps that might expect text errors in particular format.
  2. Do not output extra text when the Thrift Server outputs errors in an JSON format.

Does this PR introduce any user-facing change?

Yes.

How was this patch tested?

By running the modified tests:

$ build/sbt -Phive -Phive-thriftserver "test:testOnly *ThriftServerWithSparkContextInBinarySuite"

@MaxGekk

Copy link
Copy Markdown
MemberAuthor

Merging to master. Thank you, @HyukjinKwon for review.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@MaxGekk@cloud-fan@HyukjinKwon