Uh oh!
There was an error while loading. Please reload this page.
[SPARK-42136] Refactor BroadcastHashJoinExec output partitioning calculation - #38038
Closed
peter-toth wants to merge 2 commits into
Closed
Conversation
peter-tothforce-pushed
the
SPARK-refactor-broadcasthashjoinexec-output-partitioning
branch
from
September 28, 2022 18:41
ee15d1e to
e49b90cComparepeter-tothforce-pushed
the
SPARK-refactor-broadcasthashjoinexec-output-partitioning
branch
from
December 27, 2022 14:33
e49b90c to
e656ae7Comparepeter-tothforce-pushed
the
SPARK-refactor-broadcasthashjoinexec-output-partitioning
branch
from
January 20, 2023 16:18
e656ae7 to
89065f6Comparepeter-toth
commented
Jan 20, 2023
ContributorAuthor
cc @cloud-fan |
Contributor
is this PR still up to date? |
peter-toth
commented
Jan 31, 2023
ContributorAuthor
Yes, it is. This is a simple refactor to utilize |
…136-refactor-broadcasthashjoinexec-output-partitioning
peter-toth
commented
Jan 31, 2023
ContributorAuthor
I've just updated this PR with latest |
cloud-fan
approved these changes
Jan 31, 2023
peter-toth
commented
Feb 7, 2023
ContributorAuthor
@cloud-fan, please let me know if anything is needed to get this merged. |
cloud-fan
commented
Feb 7, 2023
Contributor
thanks, merging to master! |
peter-toth
commented
Feb 7, 2023
ContributorAuthor
Thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is PR refactors
BroadcastHashJoinExecoutput partitioning calculation using the newTreeNode.multiTransformDown()helper so simplify code and improve performance.Why are the changes needed?
Simpler code with
TreeNode.multiTransform().Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing UTs.