Uh oh!
There was an error while loading. Please reload this page.
[SPARK-37555][TEST][FOLLOWUP] Increase timeout of CLI test spark-sql should pass last unclosed comment to backend - #38571
Closed
AngersZhuuuu wants to merge 6 commits into
Closed
Conversation
… should pass last unclosed comment to backend`
LuciferYang
commented
Nov 9, 2022
Contributor
flaky test? |
AngersZhuuuu
commented
Nov 10, 2022
ContributorAuthor
yea |
AngersZhuuuu
commented
Nov 14, 2022
ContributorAuthor
@cloud-fan Triggered six times, the flaky test not failed. |
cloud-fan
commented
Nov 14, 2022
Contributor
@AngersZhuuuu can you fill the PR description? Then we can merge it. |
AngersZhuuuu
commented
Nov 14, 2022
ContributorAuthor
done |
cloud-fan
commented
Nov 14, 2022
Contributor
thanks, merging to master! |
SandishKumarHN pushed a commit
to SandishKumarHN/spark
that referenced
this pull request
Dec 12, 2022
… should pass last unclosed comment to backend` ### What changes were proposed in this pull request? Fix flaky test `spark-sql should pass last unclosed comment to backend`, it's timeout should be caused by unstable GA env, so I increase timeout time for the test ### Why are the changes needed? Fix flaky test. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Not need Closesapache#38571 from AngersZhuuuu/SPARK-37555-FOLOWUP. Authored-by: Angerszhuuuu <angers.zhu@gmail.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix flaky test
spark-sql should pass last unclosed comment to backend,it's timeout should be caused by unstable GA env, so I increase timeout time for the test
Why are the changes needed?
Fix flaky test.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Not need